Skip to content

makestudy and makedocker exit 0 when they fail #679

Open

Description

@chikolavosaki-sys

makestudy and makedocker exit 0 when they fail, so callers can't detect the failure.

Steps (dev @ 8f3e444, Ubuntu 24.04 on WSL2):

./makestudy demo/does_not_exist; echo $?          # "does not exist", exit 0
./makestudy demo/sample.graphml /tmp; echo $?     # "already exists", exit 0
./makedocker demo/sample.graphml /tmp; echo $?    # "already exists", exit 0
./makestudy; echo $?                              # usage text, exit 0

Every error path ends with a bare exit, which returns the status of the echo just before it. In makedocker, the "already exists" branch has no exit at all.

This matters because the FRI server (fri/server/main.py, /build) runs these scripts with subprocess.check_output and only reports an error on a non-zero exit code. A failed study creation is therefore returned as 201 "Directory successfully created".

I'd like to work on this.

Activity

  1. github-actions commented on Nov 13, 2026

    @github-actions

    👋 Welcome to the CONTROL-CORE Project, @chikolavosaki-sys! Thank you for opening your first issue in concore.
    We appreciate your contribution to the organization and will review it as soon as possible.

    Before we get started, please check out these resources:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions