You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CI: run the Python test suite on Windows and macOS #675
Problem: the Python test job in .github/workflows/ci.yml runs only on ubuntu-latest (it varies the Python version, not the OS). Windows and macOS only run the Julia and C++ jobs. The CLI and the mkconcore.py script generation, including the Windows .bat scripts and the macOS/posix paths, are never tested on those systems in CI. Windows-specific bugs such as the quoting problems in run.bat/debug.bat are only found after merge, by users. Contributors on macOS also see failures (for example in the shared-memory tests) that CI never shows.
Proposal: add a separate test-os job that runs the existing pytest suite on windows-latest and macos-latest (Python 3.11, fail-fast: false). The existing Ubuntu test job stays unchanged. I would:
run it once non-blocking to get the real list of failures on each OS,
fix the ones that are real bugs, in small PRs,
skip the ones that cannot work on that OS, each with a reason in the test,
only then ask for the new job to be treated as required.
I'm happy to do all of this. Is this a direction you'd accept, and are there tests that you already know are Linux-only?
👋 Welcome to the CONTROL-CORE Project, @yadavchiragg! Thank you for opening your first issue in concore.
We appreciate your contribution to the organization and will review it as soon as possible.
Before we get started, please check out these resources:
Update: I ran the proposed job on my fork as a dry run. Results:
windows-latest: the full Python suite passes, so adding it needs no fixes.
macos-latest: 232 passed, 6 failed. All 6 are the shared-memory C++ tests (test_shm_abort x4, test_shm_lifecycle x2); the C++ helper dies with an uncaught exception from shmget/shared-memory setup on macOS. I propose skipping those on macOS with a clear reason (and opening a separate issue for them) unless you'd prefer a fix.
Separately, the existing Ubuntu test job with Python 3.9 fails on the new ubuntu-latest (26.04) because that image has no Python 3.9.
I'll wait for your go-ahead before opening a PR for the workflow change.
Update on the macOS failures: I found the cause. The shared-memory transport in concore.hpp is compiled only under #ifdef __linux__, so on macOS write_SM has no segment and throws, and tests/test_shm_abort.py / tests/test_shm_lifecycle.py (6 tests) fail. These tests can only pass on Linux. My proposal is to skip them off Linux with a clear reason, as a 2-file change (10 lines). I'll wait for your go-ahead before opening a PR for that or for the workflow change. @pradeeban
Activity
github-actions commentedon Nov 13, 2026
👋 Welcome to the CONTROL-CORE Project, @yadavchiragg! Thank you for opening your first issue in concore.
We appreciate your contribution to the organization and will review it as soon as possible.
Before we get started, please check out these resources:
yadavchiragg commentedon Nov 13, 2026
Update: I ran the proposed job on my fork as a dry run. Results:
shmget/shared-memory setup on macOS. I propose skipping those on macOS with a clear reason (and opening a separate issue for them) unless you'd prefer a fix.testjob with Python 3.9 fails on the new ubuntu-latest (26.04) because that image has no Python 3.9.I'll wait for your go-ahead before opening a PR for the workflow change.
yadavchiragg commentedon Nov 14, 2026
Update on the macOS failures: I found the cause. The shared-memory transport in
concore.hppis compiled only under#ifdef __linux__, so on macOSwrite_SMhas no segment and throws, andtests/test_shm_abort.py/tests/test_shm_lifecycle.py(6 tests) fail. These tests can only pass on Linux. My proposal is to skip them off Linux with a clear reason, as a 2-file change (10 lines). I'll wait for your go-ahead before opening a PR for that or for the workflow change. @pradeeban