Repository navigation
Conversation
Draining stdout after the process exits appended to log_line_buffer, which is never defined, so any leftover output turned a finished command into {'success': False, 'error': "name 'log_line_buffer' is not defined"}.
Contributor
|
Hi @kayaal34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Sandbox.run(AutoCua/windows/sandbox/service.py), when the process has exited, the loop that collects the remaining stdout also doeslog_line_buffer += char.log_line_bufferis never defined, so whenever output was still queued at exit, theNameErrorwas caught by the outerexceptand a finished command came back as{"success": False, "error": "name 'log_line_buffer' is not defined"}, losing its output and return code. The variable is not used anywhere else, so this removes the line.How I tested it
ruff check --select F821is clean on the file. I did not run the Windows sandbox.I used Claude (an AI assistant) to help with this change; I reviewed it and ran the check above.