People don't wanna vote and I don't get why - #120
Conversation
b4cceac to
a89ca96
Compare
|
It is not a new issue I'm pretty sure - I can fix with more functions but I don't think it's necessary |
| _, _, err = slackData.Client.PostMessage(slackData.AnnouncementsChannel, | ||
| slack.MsgOptionText("It has been past the default time required to vote on \""+poll.Title+ | ||
| "\" These people have not completed their responsibility as a Voting Member of House. \n"+ | ||
| strings.Join(notVotedString, ","), false)) |
| logging.Logger.WithFields(logrus.Fields{"method": "EvaluatePolls dm"}).Error(err) | ||
| continue | ||
| } | ||
| notVotedString = append(notVotedString, "<@"+user.SlackUID+">") |
There was a problem hiding this comment.
nit: what if the user doesn't have a slack UID set?
| if user.SlackUID != "" { | ||
| notVotedString = append(notVotedString, "<@"+user.SlackUID+">") | ||
| } else { | ||
| notVotedString = append(notVotedString, user.Username) | ||
| } |
There was a problem hiding this comment.
If the SlackUID is empty, I think the the slack message send will error first, and then this won't add the username.
There was a problem hiding this comment.
I think i fixed this? i don't know if I completely understand what you're asking for
There was a problem hiding this comment.
I guess it's sorta fixed? It's a little odd to do X, do Y, and then check if X errored...
480c2c3 to
6a0a8bf
Compare
tallen42
left a comment
tallen42
left a comment
There was a problem hiding this comment.
ship it. ship it ship it ship it. hollllyyy ship it.
|
4 participants
What
Outs people in announcements if they don't vote
Why
It's Friday and we still haven't hit quorum on a vote released last Saturday
Test Plan
How do I test slack pinging in announcements? Do we first have to grant the bot privileges to?
Env Vars
No
Documentation
Erm.... no
Checklist