Repository navigation
Conversation
parse_kcat_source and format_kcat_source read and write <origin>[ (<detail>)][ | tuned=<methods> (prior=<value>)]. The writers build their strings with the formatter and the readers use the parsed origin. set_kcat_for_reactions writes manual. sensitivity_tuning and cmaes_kcat_tuning keep the origin and detail and add the tuning method, with the kcat before the first tuning as prior, and sensitivity_tuning no longer writes the old source into ec.notes. A standard row with a tuning status is kept by assign_standard_kcat and remove_standard_kcat.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_kcat_sourceandformat_kcat_sourceread and write the provenance text ofmodel.ec.source,<origin>[ (<detail>)][ | tuned=<method>[+<method>...] (prior=<value>)], for examplebrenda (wc=0, origin=2) | tuned=cmaes (prior=6.55), andKcatSourceholds the parts of one.format_kcat_source(origin, detail=None, tuned=(), prior=None)replacesformat_kcat_source(source, wildcard_level, origin)and writes the same string for the same non-empty source, wildcard level and origin. Every writer builds its text with the formatter, and the readers use the parsed origin, so a source with a detail or a tuning status is recognised.set_kcat_for_reactionswrites the originmanual(it wrotesetKcatForReactions) and drops any tuning status.sensitivity_tuningandcmaes_kcat_tuningkeep the origin and detail of every kcat they change and add the method (sensitivity,cmaes) to its tuning status, with the kcat before the first tuning asprior.sensitivity_tuningno longer writes the old kcat and source intoec.notes.assign_standard_kcatandremove_standard_kcatkeep a standard row that has a tuning status.Part of raven-gecko-parity#151.