Repository navigation
fix: omit unset enableUspsCass from Address Validation requests - #7
Draft
illuminati1911 wants to merge 1 commit into
Draft
illuminati1911 wants to merge 1 commit into
illuminati1911 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableUspsCassin the JSON request only when its value is notNone.TrueandFalsevalues.The existing condition is always true, including for the default
Nonevalue, so an omitted option is sent as JSON null: https://github.com/googlemaps/google-maps-services-python/blob/d3b71ab1333cff0f900d2db6b39c1356341a5ea2/googlemaps/addressvalidation.py#L47-L75This corrects unintended serialization; it does not claim that the API rejects null. The existing documentation and response handling are otherwise unchanged.
Verification
python -m pytest tests/test_addressvalidation.py— 1 passed, covering omitted, true, and false serialization cases.python -m pytest— 105 passed.None,True, andFalseinputs. Confirmed successful results and preservation of other address fields. No Google Maps requests or real credentials were used.nox --download-python never -s docs --force-python 3.10— passed. Visually inspected generated Sphinx documentation and the rendered changelog in Chromium.