Repository navigation
fix: raise errors for unsuccessful Address Validation responses - #6
Draft
illuminati1911 wants to merge 1 commit into
Draft
illuminati1911 wants to merge 1 commit into
illuminati1911 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiErrorwith Google's structured status and message for unsuccessful Address Validation responses.HTTPErrorfor non-JSON or malformed error bodies instead of returning error payloads or leaking JSON decoding errors.The existing extractor returns parsed JSON without checking the HTTP status: https://github.com/googlemaps/google-maps-services-python/blob/d3b71ab1333cff0f900d2db6b39c1356341a5ea2/googlemaps/addressvalidation.py#L25-L44
Structured error parsing follows Google's HTTP/JSON error format: https://google.aip.dev/193#http11json-representation
Verification
python -m pytest tests/test_addressvalidation.py— 5 passed.python -m pytest— 109 passed.nox --download-python never -s docs --force-python 3.10— passed. Visually inspected generated Sphinx documentation and the rendered changelog in Chromium.