Repository navigation
feat: support extra computations in forward geocoding - #11
Draft
illuminati1911 wants to merge 1 commit into
Draft
illuminati1911 wants to merge 1 commit into
illuminati1911 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra_computationstogeocode()forADDRESS_DESCRIPTORSandBUILDING_AND_ENTRANCES, accepting a string or list of strings.Noneand an empty list omit the parameter.The existing forward-geocoding signature does not expose this option: https://github.com/googlemaps/google-maps-services-python/blob/d3b71ab1333cff0f900d2db6b39c1356341a5ea2/googlemaps/geocoding.py#L22-L23
The supported values and repeated-key format are documented here: https://developers.google.com/maps/documentation/geocoding/guides-v3/requests-geocoding
Verification
On Python 3.10.20:
python -m pytest tests/test_geocoding.py— 21 passed, including 4 new feature tests.python -m pytest— 109 passed.nox --download-python never -s docs --force-python 3.10— repository Sphinx build passed; visually inspected the public documentation and rendered changelog.The prescribed Python 3.7 docs build remains unverified because that interpreter is unavailable. The Python 3.10 build is supplemental. Tests ran directly using the repository's test dependencies, avoiding the automatic Codecov upload.