Repository navigation
London | 26-Jul-SDC | Alex Jamshidi | Sprint 5 | Implement laptop allocation - #685
Alex-Jamshidi wants to merge 6 commits into
Conversation
This README provides an overview of the Laptop Allocation Program, including its purpose, specifications, running instructions, and details about the allocation and simulation processes.
Corrected spelling of 'allocate' and removed extra newline.
Alex-Jamshidi
added
Needs Review
LonMcGregor
added
the
Review in progress
|
Your PR included an an unrecognised Task ID. Make sure you have put the correct Task ID in its description. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Apologies for the delay in the review.
You've gone into a lot of detail preparing this, good work.
I've got a few questions to assess your understanding of the code.
There was a problem hiding this comment.
Thanks for writing this readme, it's always good to see programs documented well like this.
| name: str | ||
| age: int | ||
| # Sorted in order of preference, most preferred is first. | ||
| preferred_operating_systems: tuple[OperatingSystem, ...] |
There was a problem hiding this comment.
Is there a reason you use a tuple here? Is there an advantage of that over another type of structure?
| person_costs.append(sadness) | ||
| cost_matrix.append(person_costs) | ||
|
|
||
| row_ind, col_ind = linear_sum_assignment(cost_matrix) |
There was a problem hiding this comment.
Using this algorithm is a good way of optimising laptop assignment. I have a couple of questions:
- What do you think the complexity of this approach is?
- Does this algorithm have any drawbacks or limitations?
- Do you understand how this algorithms works? Can you briefly describe it?
LonMcGregor
added
Reviewed
|
Your PR included an an unrecognised Task ID. Make sure you have put the correct Task ID in its description. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
We've updated the tasks for the next SDC that is running, so you can ignore what the bot is telling you about a missing task code. |
2 participants
Learners, PR Template
Self checklist
Task code
CYF-1156
Changelist
Program to assign laptops to people in the most effective way possible.
Uses Hungarian Algorithm to assign.
Contains simulation for different scenarios.
Can handle when there are more people than laptops.