Skip to content

Manchester | 26-Jun-SDC | Fithi Teklom | Sprint 1 | Hashtag Slowing Down - #298

Open
Fithi-Teklom wants to merge 2 commits into
CodeYourFuture:mainfrom
Fithi-Teklom:feature/hashtag-slowing-down
Open

Fithi-Teklom wants to merge 2 commits into
CodeYourFuture:mainfrom
Fithi-Teklom:feature/hashtag-slowing-down

Conversation

@Fithi-Teklom

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1170

Changelist

#Fix
-Fixed an infinite fetch loop on hashtag pages by preventing repeated API requests for the current hashtag.

##Test
-Hashtag pages load without repeated requests.
-Other hashtags still work correctly.

@Fithi-Teklom Fithi-Teklom added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 9, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You change two files here, so both check the state. Does the same change need to be made in both files?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 13, 2026
@Fithi-Teklom Fithi-Teklom added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 22, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, the bug is fixed now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants