Repository navigation
Manchester | 26-Jun- SDC | Fithi Teklom | Sprint 1 | Hashtag Link - #297
Open
Fithi-Teklom wants to merge 2 commits into
Open
Fithi-Teklom wants to merge 2 commits into
Fithi-Teklom wants to merge 2 commits into
Conversation
Fithi-Teklom
added
the
Needs Review
LonMcGregor
reviewed
Oct 13, 2026
There was a problem hiding this comment.
Is this file meant to be committed here?
There was a problem hiding this comment.
Good start, consider though that something like #hash-tag . is that a valid tag?
LonMcGregor
added
Reviewed
Fithi-Teklom
force-pushed
the
feature/hashtag-link
branch
from
October 22, 2026 20:33
8381bcb to
b4edc71
Compare
Fithi-Teklom
added
Needs Review
LonMcGregor
reviewed
Oct 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, this task is complete now
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1169
Changelist
Fixed hashtag parsing so hashtag links only include valid hashtag characters.