Repository navigation
Manchester | 26-ITP-Sept | Monsur Abdulrahman | Sprint 1 | Coursework/form control - #1645
Open
Monsur0001 wants to merge 9 commits into
Open
Monsur0001 wants to merge 9 commits into
Monsur0001 wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Monsur0001
added
🏕 Priority Mandatory
hackertainment
added
Review in progress
There was a problem hiding this comment.
Your code is correct. However, it would be nice to improve the following in the future:
- indentation - should be clear enough to read blocks and sub-blocks
- consistent format - some
<meta>tags and<input>tags etc are in one line and some are in multiple lines which are not consistent and hard to read. I personally would suggest one line for clarity, especially the program would be very long if tags with lots of attributes in multiple lines. - use of dropdown list and radio buttons - just to give you a thought, and there is no right or wrong about UI design but about better experience for users. I personally would use dropdown list for size (which has more options) and radio buttons for colour (which has just 3 options). Still it really depends on the context or conventions as well, and feel free to explore/discuss with other trainees on Saturday study group.
- look and feel - I really love your beautiful form. Just a friendly reminder that in the coming more complexed courseworks, complete necessary features first before making the UI beautiful. Code Your Future (and many companies) prioritise functionality/usability of program over UI design, and many trainees created a very beautiful layout without enough time to complete the required criteria, and as a result failed the project or the course. Again, I appreciate beautiful UI design and your great effort, and I hope you success without falling into such situation of some previous trainees. :-)
Congratulation, you have completed this PR successfully. Keep it up.
| @@ -1,27 +1,99 @@ | |||
| <!DOCTYPE html> | |||
| <!doctype html> | |||
There was a problem hiding this comment.
Although HTML is not case sensitive, I think the original code <!DOCTYPE html> is correct by convention.
Author
There was a problem hiding this comment.
Thank you so much for taking your time to review my code and giving me such detailed feedback, I will work on those suggestions. Thank you so much
hackertainment
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1004
Changelist