Repository navigation
NW6| Fikret Ellek | JS3- CodeAlong-NumberFacts | Week 2 - #29
Open
fikretellek wants to merge 1 commit into
Open
fikretellek wants to merge 1 commit into
fikretellek wants to merge 1 commit into
Conversation
pseudopilot
reviewed
Apr 30, 2024
pseudopilot
left a comment
pseudopilot
left a comment
There was a problem hiding this comment.
Great work! Just left one comment for you.
Comment on lines
+67
to
+71
| factCont.style.display = "block"; | ||
|
|
||
| if (number === "") { | ||
| factCont.style.display = "none"; | ||
| } |
There was a problem hiding this comment.
I like both of your implementations of getFactFetch 👍 .
A little comment regarding factCont.style.display. For such cases when we want to assign one or another value to some variable depending on some condition there is a commonly used ternary operator in JS (you can read more about it here https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Conditional_operator)
Long story short, you can simplify this part of code the following way:
factCont.style.display = number === "" ? "none" : "block";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.