Skip to content

NW6| Sabella Fisseha | JS3- CodeAlong-NumberFacts | Week 2 - #27

Open
Sabella-8 wants to merge 2 commits into
CodeYourFuture:mainfrom
Sabella-8:main
Open

Sabella-8 wants to merge 2 commits into
CodeYourFuture:mainfrom
Sabella-8:main

Conversation

@Sabella-8

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@SpectacularLandscape SpectacularLandscape left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good @Sabella-8. Just make sure you are using Prettier to format your code ⌨️

Comment thread index.html
let number = numberInput.value;

fetch('http://numbersapi.com/'+ number)
.then(Response => Response.text())

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally variables in JavaScript don't start with an uppercase letter. You can see this has confused the GitHub syntax highlighter as well, as it is a different colour to normal variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants