Repository navigation
Update Text Container Width Correctly - #177
Merged
thecoolwinter merged 3 commits intoApr 22, 2023
Merged
Conversation
thecoolwinter
requested review from
austincondiff,
lukepistrol and
matthijseikelenboom
April 21, 2023 17:22
lukepistrol
reviewed
Apr 22, 2023
lukepistrol
approved these changes
Apr 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
wrapLinessetting to affect the text view's text container size. This fixes the horizontal scrolling bugs seen recently. In effect, it locks the width of the text view to the width of the visible container whenwrapLinesis set totrue, and lets the text view determine it's own width whenfalse.This is done by accounting for the ruler view size when
wrapLinesis set to true. It also makes sure to update the text container and text view frame size as needed when the ruler or window size change and when thewrapLinessetting is updated.Related Issues
Checklist
Screenshots
Screen.Recording.2023-04-21.at.12.18.29.PM.mov