Repository navigation
Add contentInsets Parameter - #141
Merged
Merged
Conversation
Wouter01
previously approved these changes
Feb 14, 2023
Member
|
I'll give it a go tomorrow, but looks good! |
Collaborator
Author
|
Ready to review, just added some tests and fixed to pass the failing ones. |
thecoolwinter
dismissed stale reviews from Wouter01 and austincondiff
via
February 15, 2023 01:59
dbc93c3
Wouter01
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
contentInsetsparameter that lets users set an inset object for the editor. It also updatesSTTextViewto be able to set the left inset correctly. When leftnilthe scroll view will use automatic insets.This also doesn't override the overscroll option, but rather adds the overscroll after the insets are applied.
Related Issues
Screenshots
Adding top and left insets:
Adding left and bottom insets (scroller is also inset):
