Skip to content

feat: Define comment strings for each language - #65

Merged
FastestMolasses merged 7 commits into
CodeEditApp:mainfrom
Qubik65536:feat/comment-definition
Apr 11, 2024
Merged

FastestMolasses merged 7 commits into
CodeEditApp:mainfrom
Qubik65536:feat/comment-definition

Conversation

@Qubik65536

@Qubik65536 Qubik65536 commented Feb 9, 2024 •

Copy link
Copy Markdown
Contributor

Signed-off-by: Qian Qian "Cubik"‎ cubik65536@cubik65536.top

Description

Add comment string definitions for each language so the feature to press ⌘ + / to comment a line or a block of codes can be provided.

Related Issues

  • n/a

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

n/a

Qubik65536 and others added 4 commits February 7, 2024 13:09
…ift definition

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@Qubik65536

Copy link
Copy Markdown
Contributor Author
CodeLanguage+Definitions.swift:463:1: error: File Length Violation: File should contain 400 lines or less: currently contains 463 (file_length)

That's even with some definitions missing...

Any ideas what we can do with this? /cc @thecoolwinter

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@Qubik65536
Qubik65536 marked this pull request as ready for review March 15, 2024 23:58
@Qubik65536 Qubik65536 changed the title [WIP] feat: Define comment strings for each language feat: Define comment strings for each language Mar 16, 2024
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

@austincondiff austincondiff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the effort here!

@FastestMolasses
FastestMolasses merged commit 534853a into CodeEditApp:main Apr 11, 2024
zxss702 pushed a commit to zxss702/CodeEditLanguages that referenced this pull request Jul 20, 2026
* feat: Add basic implementation for language comment definition and Swift definition

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* refactor: Improved documentation comment strings definition

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* feat: Add comment definition for `agda`, `bash`, `c`, and `cpp`

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* feat: Add some other language comments' definition

* style: Fix some SwiftLint issue

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* feat: Add Java documentation string

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* Disable File Length Check for Code Language Definition

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

---------

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Co-authored-by: Evren Sen <146845123+evrsen@users.noreply.github.com>
zxss702 pushed a commit to zxss702/CodeEditLanguages that referenced this pull request Jul 20, 2026
* feat: Add basic implementation for language comment definition and Swift definition

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* refactor: Improved documentation comment strings definition

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* feat: Add comment definition for `agda`, `bash`, `c`, and `cpp`

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* feat: Add some other language comments' definition

* style: Fix some SwiftLint issue

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* feat: Add Java documentation string

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* Disable File Length Check for Code Language Definition

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

---------

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Co-authored-by: Evren Sen <146845123+evrsen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants