Skip to content

fixed duplicate files in build configuration, fixme is not a valid item identifier - #228

Merged
lukepistrol merged 1 commit into
CodeEditApp:mainfrom
lukepistrol:main
Mar 24, 2022
Merged

lukepistrol merged 1 commit into
CodeEditApp:mainfrom
lukepistrol:main

Conversation

@lukepistrol

Copy link
Copy Markdown
Member

Description

  • Removed duplicate files from Compile Sources in Build Phases.
  • Removed fixme from SwiftLintconfig since it is included in the todo tag.

Checklist (for drafts):

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • Review requested

@lukepistrol lukepistrol added the bug Something isn't working label Mar 24, 2022
@lukepistrol
lukepistrol merged commit 37c6ec2 into CodeEditApp:main Mar 24, 2022
xinix909 pushed a commit to xinix909/CodeTransfer that referenced this pull request Sep 7, 2024
<!--- IMPORTANT: If this PR addresses multiple unrelated issues, it will
be closed until separated. -->

### Description

Makes JSDocs highlight as comments. Because they're injected as a
different language they don't get captured normally. This is the only
language we have to handle this in so it's hard-coded in the
TreeSitterClient.

Also adds a quick check to prevent potential recursive cursor
notifications using SwiftUI.

### Related Issues

<!--- REQUIRED: Tag all related issues (e.g. * CodeEditApp#123) -->
<!--- If this PR resolves the issue please specify (e.g. * closes CodeEditApp#123)
-->
<!--- If this PR addresses multiple issues, these issues must be related
to one other -->

* [Discord
conversation](https://canary.discord.com/channels/951544472238444645/987416899816149024/1201620579590090853)

### Checklist

<!--- Add things that are not yet implemented above -->

- [x] I read and understood the [contributing
guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)
as well as the [code of
conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots

<img width="285" alt="Screenshot 2024-02-02 at 7 37 19 PM"
src="https://github.com/CodeEditApp/CodeEditSourceEditor/assets/35942988/f201e5ff-1bf9-4bb5-97fb-0914aa66246a">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant