Preference View by underthestars-zhy · Pull Request #205 · CodeEditApp/CodeEdit

underthestars-zhy · 2022-03-23T11:17:03Z

Description

Preference Tab View
New Tabs

Releated Issue

#146
#286

Checklist (for drafts):

I read and understood the contributing guide as well as the code of conduct
My changes generate no new warnings
My code builds and runs on my machine
Review requested

Screenshots (if appropriate):

CleanShot.2022-03-23.at.21.56.32.mp4

Use keyboard change themes

CleanShot.2022-03-24.at.19.10.33.mp4

Signed-off-by: Underthestars-zhy <zhuhaoyu0909@icloud.com>

austincondiff · 2022-03-26T17:36:24Z

For appearance, instead of macOS wallpaper, we need a simplified illustration of the application and code similar to this

austincondiff · 2022-03-26T18:18:45Z

I really like how Nova has done their theme selector, the thumbnails are simple and their settings react to your system appearance, very flexible. I might make thumbnails a bit smaller thought to allow for more to be seen an once.

Screen.Recording.2022-03-26.at.1.13.06.PM.mp4

austincondiff · 2022-03-26T19:45:18Z

In our theme preference pane, I would have a checkbox, a tabset, and then a "More Themes" button. In the tabset, there are three tabs - "Window", "Editor", and "Terminal". When the checkbox is clicked, A light mode and dark mode toggle appears so that users can select light mode settings and dark mode settings.

By default if their currently selected theme supports the opposite appearance mode, it is automatically chosen. For example, if there is a High Contrast theme that offers a light version and a dark version and the user is in dark mode and they select "Automatically change theme based on system appearance", High Contrast Light will automatically be used for light mode because they have previously selected High Contrast Dark while in dark mode.

austincondiff · 2022-03-26T19:48:26Z

The theme preference pane might look something like this without the left sidebar category selector...

underthestars-zhy · 2022-03-26T22:43:06Z

In our theme preference pane, I would have a checkbox, a tablet, and then a "More Themes" button. In the tabset, there are three tabs - "Window", "Editor", and "Terminal". When the checkbox is clicked, A light mode and dark mode toggle appears so that users can select light mode settings and dark mode settings.

By default if their currently selected theme supports the opposite appearance mode, it is automatically chosen. For example, if there is a High Contrast theme that offers a light version and a dark version and the user is in dark mode and they select "Automatically change theme based on system appearance", High Contrast Light will automatically be used for light mode because they have previously selected High Contrast Dark while in dark mode.

We don’t need a window theme tab now. We only have three window themes. If we add this tab the view will become ugly.

underthestars-zhy · 2022-03-26T22:49:52Z

So which theme picked we choose?
The system one or nova one.
If we have a lot of themes, system one may be a good choice.

austincondiff · 2022-03-27T08:38:49Z

Something like this...

underthestars-zhy · 2022-03-27T08:54:50Z

Something like this...

So how can people choose auto themes?

underthestars-zhy · 2022-03-27T13:51:13Z

For appearance, instead of macOS wallpaper, we need a simplified illustration of the application and code similar to th

fixed

austincondiff · 2022-03-27T16:41:22Z

So how can people choose auto themes?

You would check the “automatically change theme based on system appearance” checkbox.

If you notice, in the first mock up that check box is unchecked. When it is unchecked there is only one preview thumbnail to the right. When it is checked there are two thumbnails to the right. One for light, one for dark. When the light thumbnail is selected, you are selecting the theme below that will be applied when the system is in light mode. When the dark thumbnail is selected at the top right, the user can then select the dark theme to use when the system is in dark mode. The thumbnails at the top act as tabs to make a selection for each mode.

austincondiff · 2022-03-27T21:33:40Z

Opening a new issue for the design preference tab.

austincondiff · 2022-03-27T21:36:33Z

Appearance option thumbnails need "Light" and "Dark" labels like in macOS system preferences. Reopen behavior and icon style should instead be select menus for better clarity.

lukepistrol

The alignment in Terminal Settings is not quite right yet, also make sure all options are available and clear to understand (see review comments).

Current Main

This PR

lukepistrol · 2022-03-28T10:11:52Z

      {
        "package": "Highlightr",
-        "repositoryURL": "https://github.com/raspu/Highlightr.git",
+        "repositoryURL": "https://github.com/raspu/Highlightr",


leave .git

It seems work well in my mac.

lukepistrol · 2022-03-28T10:13:51Z

+import FontPicker
+import Preferences
+
+struct ExecutionSettingsView: View {


Why execution and not terminal ?

This will change. Terminal part will move to the theme tab.

The alignment in Terminal Settings is not quite right yet, also make sure all options are available and clear to understand (see review comments).

Current Main

This PR

Fixed

lukepistrol · 2022-03-28T10:17:20Z

+                }
+
+                Preferences.Section(title: "Terminal Color:") {
+                    if colorScheme == .dark {


Don't switch on colorScheme. Normal and Light colors are used in both dark and light appearance

lukepistrol · 2022-03-28T10:17:53Z

+                        }
+                    }
+                }
+            }


Add Reset Defaults button like on current main.

lukepistrol · 2022-03-28T10:19:17Z

+                }
+
+                Preferences.Section(title: "Terminal Font:") {
+                    Toggle(isOn: $customFont) {


Use a separate line for switching between system and custom font. With the font picker only shown when custom is selected. like on current main

But I don't think this design will cause misunderstanding. And the content can be reduced.

Having an unlabeled checkbox near a font selector will most likely lead to misunderstandings.

# Conflicts: # CodeEdit.xcodeproj/project.pbxproj # CodeEdit/Settings/GeneralSettingsView.swift

### Description Adds a minimum ruler width equal to 4 digits wide to reduce layout shift while scrolling. ### Related Issues    * N/A, discussed a couple times in discord. ### Checklist  - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [x] I documented my code ### Screenshots Previous: <img width="356" alt="Screenshot 2023-07-11 at 12 28 26 PM" src="https://github.com/CodeEditApp/CodeEditTextView/assets/35942988/469044fa-189f-41d8-83ca-367f2244fe82"> Now: <img width="321" alt="Screenshot 2023-07-11 at 12 27 51 PM" src="https://github.com/CodeEditApp/CodeEditTextView/assets/35942988/547dcdda-f50e-4be6-a065-7fef5b6e7cd7">

underthestars-zhy added 7 commits March 23, 2022 19:12

Fix doesn't show icon bug

84b87d8

little update

cff60e9

Merge remote-tracking branch 'upstream/main'

f2ea862

bug fix

c8c24b9

choose theme

ac086b2

New tabs

ce4c4a0

Remove useless stuff

a95d7be

pkasila marked this pull request as ready for review March 23, 2022 14:27

pkasila marked this pull request as draft March 23, 2022 14:27

underthestars-zhy added 17 commits March 24, 2022 17:46

Merge remote-tracking branch 'upstream/main'

061faf4

small update

c26d4fa

Cutom Termial Font

3cb75ad

Keyboard

d327204

Merge remote-tracking branch 'upstream/main'

7d1f83e

small change

547ba62

Signed-off-by: Underthestars-zhy <zhuhaoyu0909@icloud.com>

Packages

ccf4336

Custom Preferences Package

68f456a

Signed-off-by: Underthestars-zhy <zhuhaoyu0909@icloud.com>

Small changes

69165bb

changes

9eefbee

changes

72f5012

changes

0cb0ecd

Bug Fix

1173898

changes

79227c3

Bug Fix

ef4bd20

bug fux

879b6db

new general appearence

420c275

underthestars-zhy marked this pull request as ready for review March 24, 2022 12:46

lukepistrol requested a review from pkasila March 24, 2022 12:54

underthestars-zhy marked this pull request as draft March 24, 2022 22:28

Merge remote-tracking branch 'upstream/main'

ef28bcf

underthestars-zhy added 2 commits March 26, 2022 13:52

new color choose

48945a3

terminal color

7a87baa

underthestars-zhy added 3 commits March 27, 2022 20:24

Merge remote-tracking branch 'upstream/main'

bc07c20

new appearence image

216e41c

new reopen image

bf77ae2

pkasila self-requested a review March 28, 2022 10:08

lukepistrol requested changes Mar 28, 2022

View reviewed changes

lukepistrol added enhancement New feature or request UI This is UI related labels Mar 28, 2022

austincondiff mentioned this pull request Mar 28, 2022

✨ Themes Settings #286

Closed

lukepistrol added the clarification needed Further information is requested label Mar 29, 2022

lukepistrol marked this pull request as draft March 29, 2022 00:31

underthestars-zhy added 4 commits March 29, 2022 18:18

for merge

654458a

Merge remote-tracking branch 'upstream/main'

ceb1098

# Conflicts: # CodeEdit.xcodeproj/project.pbxproj # CodeEdit/Settings/GeneralSettingsView.swift

bug fux

c103e2c

bug fix

444eab7

underthestars-zhy closed this Mar 30, 2022

Conversation

underthestars-zhy commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Releated Issue

Checklist (for drafts):

Screenshots (if appropriate):

Uh oh!

austincondiff commented Mar 26, 2022

Uh oh!

austincondiff commented Mar 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

austincondiff commented Mar 26, 2022

Uh oh!

austincondiff commented Mar 26, 2022

Uh oh!

underthestars-zhy commented Mar 26, 2022

Uh oh!

underthestars-zhy commented Mar 26, 2022

Uh oh!

austincondiff commented Mar 27, 2022

Uh oh!

underthestars-zhy commented Mar 27, 2022

Uh oh!

underthestars-zhy commented Mar 27, 2022

Uh oh!

austincondiff commented Mar 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

austincondiff commented Mar 27, 2022

Uh oh!

austincondiff commented Mar 27, 2022

Uh oh!

lukepistrol left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

underthestars-zhy commented Mar 23, 2022 •

edited

Loading

austincondiff commented Mar 26, 2022 •

edited

Loading

austincondiff commented Mar 27, 2022 •

edited

Loading