Repository navigation
Fix no icon of settings view problem and new theme tab - #163
Closed
underthestars-zhy wants to merge 3 commits into
Closed
underthestars-zhy wants to merge 3 commits into
underthestars-zhy wants to merge 3 commits into
Conversation
underthestars-zhy
changed the title
pkasila
requested changes
Mar 22, 2022
pkasila
left a comment
pkasila
left a comment
Member
There was a problem hiding this comment.
Implement theme selection in ThemeSettingsView (and then remove it from GeneralSettingsView, leave separate tab), use Color.accentColor
Comment on lines
+20
to
+37
| VStack { | ||
| VStack { | ||
| themeItem.image | ||
| .resizable() | ||
| .frame(width: 116, height: 62) | ||
| .scaledToFit() | ||
| .border(Color(hexadecimal: "737373"), width: 1.5) | ||
| .cornerRadius(3) | ||
|
|
||
| Text(themeItem.name) | ||
| .font(.system(size: 12)) | ||
| .multilineTextAlignment(.center) | ||
| } | ||
| .padding(5) | ||
| .background(BackGroundView(seelected: themeItem.selected(editorTheme))) | ||
| } | ||
| .frame(width: 120) | ||
| .padding() |
Member
There was a problem hiding this comment.
In ThemeSettingsView, as I understand, there should be selection of themes, not just displaying of the current theme.
| } | ||
|
|
||
| struct BackGroundView: View { | ||
| let seelected: Bool |
Member
There was a problem hiding this comment.
Fix typo: seelected to selected
| var body: some View { | ||
| if seelected { | ||
| // Color(hexadecimal: "464546").cornerRadius(4) | ||
| Color(hexadecimal: "0158D0").cornerRadius(5) |
Author
|
Because, they is a lot of changes. So I will delete this fork, and create new one |
xinix909
pushed a commit
to xinix909/CodeTransfer
that referenced
this pull request
Sep 7, 2024
<!--- IMPORTANT: If this PR addresses multiple unrelated issues, it will be closed until separated. --> ### Description 1. Add 20 pixels of inset to the left of the ruler and 8 pixels of inset to the right of the ruler. I tried to match it as close as possible to Xcode. 2. Set the background color of the highlight ruler line to the same color as the highlighted line in the textView. ### Related Issues <!--- REQUIRED: Tag all related issues (e.g. * CodeEditApp#123) --> <!--- If this PR resolves the issue please specify (e.g. * closes CodeEditApp#123) --> <!--- If this PR addresses multiple issues, these issues must be related to one other --> * closes CodeEditApp#156 * closes CodeEditApp#128 ### Checklist <!--- Add things that are not yet implemented above --> - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [x] I documented my code ### Screenshots <!--- REQUIRED: if issue is UI related --> <img width="765" alt="Screenshot 2023-03-16 at 19 05 59" src="https://user-images.githubusercontent.com/82230675/225717006-40530a7b-7864-404b-8d14-5307f6f83bdb.png"> <!--- IMPORTANT: Fill out all required fields. Otherwise we might close this PR temporarily -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setting view now shows icon. And also redesign the structure of settings.
Releated Issue
#146
Checklist (for drafts):
Screenshots (if appropriate):