[underthestars-zhy]

Description

1. Fix the problem that doesn't show icon on Setting View Tab bar2.
2. Change to the SwiftUI life cycle without any devastating problem
3. Change the picker style so it now mathes the Xcode picker version.

Releated Issue

#146

Screenshots (if appropriate):

[lukepistrol]

The system status bar is gone now (see screenshot)

also make sure to resolve SwiftLint warnings as stated in contribution guidelines.

And also don't include a Team ID on commits

[underthestars-zhy]

Fixed the problem that menus doesn't show

[lukepistrol]

Preferences is grayed out and ⌘+, doesn't work

And Dev Team ID still not removed.

Also 21 swiftlint warnings

[lukepistrol]

• Status bar is still missing items

• Settings Window not closing with ⌘ + W

[pkasila]

In this way you can both use swiftui app methods and appkit AppDelegate.

At the very beginning of the project, I made transition from SwiftUI lifecycle to AppKit's AppDelegate. This transition was made because SwiftUI doesn't have some features that same old AppKit has.

Also, we are using AppKit's way (via NSDocuments) to handle all documents (workspaces and single files). I had made this decision to use NSDocument instead of SwiftUI's DocumentGroups, because DocumentGroup works with FileWrappers which are limited, for example, you cannot access file's URL using FileWrapper.

Mixing SwiftUI lifecycle and AppKit's AppDelegate wouldn't be easy. SwiftUI's NSApplicationDelegateAdaptor was added to SwiftUI to allow only handling NSApplicationDelegate notifications. And you cannot mix for example MainMenu.xib's menu and menu elements declared in SwiftUI (soon and later menu elements will be overwritten by SwiftUI, and it happens when you open Settings).

[underthestars-zhy]

In this way you can both use swiftui app methods and appkit AppDelegate.

At the very beginning of the project, I made transition from SwiftUI lifecycle to AppKit's AppDelegate. This transition was made because SwiftUI doesn't have some features that same old AppKit has.

Also, we are using AppKit's way (via NSDocuments) to handle all documents (workspaces and single files). I had made this decision to use NSDocument instead of SwiftUI's DocumentGroups, because DocumentGroup works with FileWrappers which are limited, for example, you cannot access file's URL using FileWrapper.

Mixing SwiftUI lifecycle and AppKit's AppDelegate wouldn't be easy. SwiftUI's NSApplicationDelegateAdaptor was added to SwiftUI to allow only handling NSApplicationDelegate notifications. And you cannot mix for example MainMenu.xib's menu and menu elements declared in SwiftUI (soon and later menu elements will be overwritten by SwiftUI, and it happens when you open Settings).

This is a problem. But we can fix it. Also swiftui code is more readable.

[underthestars-zhy]

Also I can use keyboard shortcut to close the window

[underthestars-zhy]

CleanShot.2022-03-21.at.21.05.14.mp4

[underthestars-zhy]

I don't think I need to change this.

[lukepistrol]

Since our workflow is treating warnings as errors (swiftlint --strict) you have to. Otherwise the workflow will fail. See contribution guide.

[lukepistrol]

@pkasila will have a detailed look at it later today.

[underthestars-zhy]

Since our workflow is treating warnings as errors (swiftlint --strict) you have to. Otherwise, the workflow will fail. See contribution guide.

But you can see the space in apple’s file

[lukepistrol]

Look, we have rules and if you don't want to follow them you can file a new Issue where changes can be discussed. If your code does not pass the checks we cannot merge it as unmistakably stated in our contribution guidlines.

[austincondiff]

I don't think I need to change this.

I actually agree, a little whitespace once in a while is a good thing and makes the code more readable.

[0xWDG]

I don't think I need to change this.

I actually agree, a little whitespace once in a while is a good thing and makes the code more readable.

The newline is not a problem for swift lint, but the whitespace/tab indentation without code is the problem for swiftlint.

[pkasila]

Use AppDelegate instead of mixing SwiftUI lifecycle and AppDelegate.

As I stated before, I don't think that mixing SwiftUI lifecycle with AppDelegate is good. The main problem is that Preferences tab can be implemented by using NSToolbar, window.toolbarStyle = .preference and NSTabViewController inside. Alternatively, it can be implemented by using Preferences package.

So, there is no need in mixing SwiftUI lifecycle and AppKit's way with AppDelegate. Especially, if we need make workarounds to make it work correctly like changing MainMenu after it has been changed by SwiftUI lifecycle.