Repository navigation
Improve Tabs - #126
Closed
viktorstrate wants to merge 3 commits into
Closed
Improve Tabs#126viktorstrate wants to merge 3 commits into
viktorstrate wants to merge 3 commits into
Conversation
viktorstrate
force-pushed
the
improve-tabs
branch
from
March 20, 2022 21:18
80f0a28 to
a7e797b
Compare
austincondiff
requested changes
Mar 20, 2022
austincondiff
left a comment
austincondiff
left a comment
Collaborator
There was a problem hiding this comment.
Great work, however I am going to pull in some of these change into my own branch and closing this one. I have been working on an overhaul of the tab component and will incorporate menu items and keyboard shortcuts.
Author
|
Thank you, I'm excited to see where this project goes. |
Merged
xinix909
pushed a commit
to xinix909/CodeTransfer
that referenced
this pull request
Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Button wrapper around each item in TabBar into TabBarItems, since that's semantically more correct.
I don't see a case where we would have a tab bar that was not also a button?
Add context menu to TabBarItems with options to
Close Tab,Close Other Tabs,Close Tabs to the Right.