[luah5]

Description

This PR adds a preference for how files are to be encoded when read the options are:

• ascii
• iso2022JP
• isoLatin1
• isoLatin2
• japaneseEUC
• macOSRoman
• nextstep
• nonLossyASCII
• shiftJIS
• symbol
• unicode
• utf16
• utf16BigEndian
• utf16LittleEndian
• utf32
• utf32BigEndian
• utf32LittleEndian
• utf8

Related Issues

• closes ✨ Text decoding setting #1202

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code
• Rename encoding -> decoding

Screenshots

as you can see the file opens with UTF32 encoding but not in ascii

[lukepistrol]

Also the Code does not currently compile. Please always clean-build the app before pushing the changes.

[lukepistrol]

@luah5 I just pushed a couple of my proposed changes which fixed some build errors and code duplication.

It now looks like this and works as expected selection-wise:

[lukepistrol]

Could you please add some screenshots of how different encodings look like when rendered? Especially when using characters only available in a specific encoding.

[lukepistrol]

I'm pretty sure that ASCII would show something when decoding a UTF-32 string. Especially when most of the characters are also available in ASCII

[lukepistrol]

Marked as blocking since the UI part needs to be re-implemented once #1215 is merged.

Also it does not work as expected yet (see this comment)

[LostInCompilation]

Did I get it right that files which don't match the set encoding setting (in Settings pane) just open as a blank file? I would expect that displaying the file should at least be tried, rendering symbols not known in current encoding as for example question marks.
Just displaying an error about wrong encoding is also not the best I think. Since the positions then needs to fiddle around in the settings to set a matching encoding for the file to be opened.
Best would be that CodeEdit just selects the right encoding based on BOM or probability if it cannot be determined.

With the current release some files with unknown encoding just open up as empty (see #1263). If this PR gets implemented displaying a file as empty should not happen IMHO.

[luah5]

Closed due to too many merge conflicts.