Skip to content

🐞 SSH Key Picker does not work in Accounts Settings #997

Closed

Description

@MrDevel0per

Description

In Settings, under the SSH Key picker, choosing one of the options does not do anything. No new window opens, and no action is performed. The picker briefly displays the text of the selected option, but clicking Create New or Choose has no effect. Also, clicking None does not change the Picker state - it reverts back to blank.

To Reproduce

  1. Open the Settings for CodeEdit
  2. With a logged-in Git account, choose the SSH option from Clone Using:
  3. On the below SSH Key picker, try choosing different options and observe that they have no effect.

Expected behavior

When I click None, the Picker should display my selected option. When I click Choose, a window to pick your key should appear - maybe an NSOpenPanel? Another window/sheet should also appear when I choose Create New. However, nothing happens in any of these situations.

Version information

CodeEdit: [0.0.1-dev 19]
macOS: [e.g. 13.1]
Xcode: [e.g. 14.2]

Screenshots

Screen.Recording.2023-01-18.at.1.40.51.PM.mov

Related issues

Activity

  1. austincondiff commented on Feb 16, 2023

    @austincondiff
    Collaborator

    I can reproduce this and will add that this crashed shortly thereafter.

  2. moved this from 🆕 New to 📋 Todo in CodeEdit Projecton Feb 16, 2023
  3. austincondiff commented on Apr 27, 2023

    @austincondiff
    Collaborator

    Now that #1244 has been merged, I can confirm this issue still exists after the Settings refactor.

  4. changed the title [-]🐞 The SSH Key Picker's Buttons don't do anything[/-] [+]🐞 SSH Key Picker does not work in Accounts Settings[/+] on Apr 27, 2023
  5. austincondiff commented on Apr 27, 2023

    @austincondiff
    Collaborator

    This field should also be hidden if SSH is not selected above.

  6. moved this from 📋 Todo to 🏁 Complete in CodeEdit Projecton May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions