You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
🐞 Open Quickly Overlay - The vertical separator should be the same color as the horizontal separator #214
changed the title [-][BUG] - Open Quickly Overlay - The vertical separator should be the same color as the horizontal separator[/-][+]🐞 Open Quickly Overlay - The vertical separator should be the same color as the horizontal separator[/+]on Mar 31, 2022
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
The preview is also loading the entire file. We could definitely speed it up by just reading the first few lines and displaying them for the preview. Unless ofc we want it to be scrollable.
As in Xcode, there will be a toggle to turn on and off this preview at the top right of the overlay.
Clicking this toggle, changes the symbols appearance and hides the preview as shown below.
This is out of scope of this particular issue so I will go ahead and create another with the above adjustments, but the divider should be a simple separator and should not resize the split when dragged.
Activity
[-][BUG] - Open Quickly Overlay - The vertical separator should be the same color as the horizontal separator[/-][+]🐞 Open Quickly Overlay - The vertical separator should be the same color as the horizontal separator[/+]stale commentedon May 30, 2022
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
thecoolwinter commentedon Jun 5, 2022
I think this can be closed, these looks like the same color to me.
nrudnyk commentedon Jun 7, 2022
@thecoolwinter not really, looks that the problem still exist for the dark theme
nrudnyk commentedon Jun 7, 2022
moreover, there's much more important problem here
record.mov
maybe for the simplicity there's no need in previewing files?
@lukepistrol @wdg what do you think?
0xWDG commentedon Jun 7, 2022
Xcode does only show a list iirc.
for me it's ok to only show an list.
@austincondiff what do you think about this, you are better with the design :)
nrudnyk commentedon Jun 7, 2022
while file preview is cool (mos likely it is, plus it's useful), there's some cons to it:
just a few points for consideration. Sorry for bringing this up (maybe that's the wrong place)
austincondiff commentedon Jun 7, 2022
I'd prefer it with the preview, but if we include it, it needs to be fast. I believe we can get there with the new editor view.
It shouldn't be resizable and the vertical border color should match the input's bottom border.
thecoolwinter commentedon Jun 8, 2022
The preview is also loading the entire file. We could definitely speed it up by just reading the first few lines and displaying them for the preview. Unless ofc we want it to be scrollable.
austincondiff commentedon Jun 10, 2022
It should be scrollable and should use the same editor view @lukepistrol is working on. This should speed up performance.
austincondiff commentedon Feb 17, 2023
As in Xcode, there will be a toggle to turn on and off this preview at the top right of the overlay.
Clicking this toggle, changes the symbols appearance and hides the preview as shown below.
This is out of scope of this particular issue so I will go ahead and create another with the above adjustments, but the divider should be a simple separator and should not resize the split when dragged.