Skip to content

✨ Custom Font Settings #200

Closed
Closed

Description

@austincondiff

We need a custom font setting in CodeEdit.

  • The editor and terminal should both default to SF Mono.
  • The editor and terminal should have the following separate font settings.
    • Font family
    • Font size
    • Font weight
    • Line height
  • The terminal by default should use the editors font settings (with the exception of line height, should default to the same as the font size) but can be set to be different from the editors setting.

Use case: I use a powerline zsh theme which requires a custom font to display correctly. I see this...
image
when it should look like this...
image

Activity

  1. underthestars-zhy commented on Mar 23, 2022

    @underthestars-zhy

    I will add the font settings tab to the Preference view

  2. lukepistrol commented on Mar 23, 2022

    @lukepistrol
    Member

    Terminal font settings working for now

  3. austincondiff commented on Mar 23, 2022

    @austincondiff
    CollaboratorAuthor

    They do!
    image

    There is no editor font settings though

  4. lukepistrol commented on Mar 23, 2022

    @lukepistrol
    Member

    @austincondiff working on implementing an ANSI color picker now #219

  5. lukepistrol commented on Mar 23, 2022

    @lukepistrol
    Member

    There is no editor font settings though

    Yeah I guess @MarcoCarnevali should take a look at the editor font selector since he's working on the editor and I don't want to mess things up

  6. jakoritarleite commented on Mar 23, 2022

    @jakoritarleite

    It would also be nice to have an option that enables font ligatures!

  7. austincondiff commented on Mar 23, 2022

    @austincondiff
    CollaboratorAuthor

    @lukepistrol We should be using the syntax highlighting theme the user has selected to also highlight the terminal.

  8. changed the title [-][FEAT] - Custom Font Settings[/-] [+]✨ Custom Font Settings[/+] on Mar 31, 2022
  9. austincondiff commented on Apr 22, 2022

    @austincondiff
    CollaboratorAuthor

    We are just waiting on the ability to change the line height for both the editor and the terminal to be able to close this. The editor should default to 16px/1.6em/160% based on a 10px font size, and terminal should default to 10px/1em/100% (same as font size).

  10. deleted a comment from stale on Jun 23, 2022
  11. nicolasparada commented on Jan 13, 2023

    @nicolasparada

    Current line height limit is capped to 2 and that is just too low :c

  12. austincondiff commented on Jan 13, 2023

    @austincondiff
    CollaboratorAuthor

    @nicolasparada What would be an acceptable cap if not 2.0?

  13. nicolasparada commented on Jan 14, 2023

    @nicolasparada

    Dunno really.

    In VSCode, from 0 to 8 means it is a multiplier of the font size. I use 3, and the default font size of 12, meaning the line height is 36.

    In VSCode then I increase the whole zoom to 2 (140%) which increases everything up. So maybe I would need 50 of line height.

    I bet there are people that like it even more spaced :)

  14. moved this from 🆕 New to 🏁 Complete in CodeEdit Projecton Feb 17, 2023
  15. austincondiff commented on Feb 17, 2023

    @austincondiff
    CollaboratorAuthor

    Everything in the above checkbox has been implemented. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    WIPThis is work-in-progressenhancementNew feature or request

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions