Repository navigation
🐞 Source editor disappears when deleting all text #1722
Description
Description
Deleting all text from the source editor results in the source editor being replaced by a QuickLook view.
To Reproduce
- Open a project
- Open a file in the project
- Delete all of the text in the file
- Notice the source editor is replaced by a big file icon (QuickLook view)
Expected Behavior
The source editor should remain in place.
Activity
austincondiff commentedon May 17, 2024
@plbstl I believe this was introduced in your recent PR #1707. Would you be able to take a look at this one?
plbstl commentedon May 18, 2024
I see. I'm taking a look at it now
thecoolwinter commentedon May 18, 2024
Whoops, didn't see @plbstl was taking a look. I've got a PR open for this now it was a very small fix.
plbstl commentedon May 19, 2024
Oh okay. I'll also test it out
plbstl commentedon May 19, 2024
I found some issues with #1723.
Doesn't work for:
Also, it opens some binaries as text files.
pr-1723.mov
plbstl commentedon May 19, 2024
This is what #1724 looks like:
pr-1724.mov
FastestMolasses commentedon May 19, 2024
Good catch, does this PR replace the other one entirely?
plbstl commentedon May 21, 2024
Yes it does. They are both minor changes.