Repository navigation
Remove all unused epoch code - #1537
Merged
mergify[bot] merged 4 commits intoMay 17, 2019
Merged
Conversation
This was referenced May 16, 2019
foriequal0
marked this pull request as ready for review
May 17, 2019 04:32
`is_epoch_begin` flag which is determined by the result of `epoch_tranistion` call doesn't make any differences whether it is true or false since `on_new_block`, `on_epoch_begin` does nothing on it. So it is safe to remove. We can even remove reading `epoch_transition`.
`on_new_block` does nothing after removing `on_epoch_begin`
`epoch_transition` is not used anymore after removing `on_epoch_begin`
Inserted `EpochTransition` is not read anymore and inserting it does not change state. So removing it doesn't introduce breaking change unless reusing the key index.
foriequal0
force-pushed
the
feature/remove-epoch
branch
from
May 17, 2019 04:48
c3041bc to
fcace71
Compare
majecty
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revival of old patches which was rebased into #1519 with heavy modifications.
After some design changes, I decided that #1519 will be closed, and the features (last_term_id, solo force term end, etc) will be continued upon this.
This PR should not bring breaking changes
I'll check these conditions.
Resolves: #1507