Repository navigation
Remove unused epoch-related code - #1508
Merged
mergify[bot] merged 7 commits intoMay 13, 2019
Merged
Conversation
`EpochChange::{Yes,Unsure}` is never constructed. Only `EpochChange::No`
is used. We can remove these codes safely since they are dead-code after
propagating constant.
Contributor
|
@majecty Would you review it? I think you see these code more than me. |
|
@foriequal0 Could you give some brief explanation about the code structure? |
|
LGTM. |
majecty
previously approved these changes
May 3, 2019
|
Please remove the "do-not-merge" label after your progress is done. |
Contributor
Author
|
I've checked that
I think we should prepare a CI environment that tests the compatibility. |
foriequal0
changed the title
foriequal0
force-pushed
the
feature/remove-epoch
branch
from
May 7, 2019 09:27
34b7e52 to
585688d
Compare
Contributor
Author
|
@majecty I've appended more removal commits. |
`insert_pending_transition` is not used anymore after removing `EpochChange`. `get_pending_transition` should alway return `None` since there are no inserted `PendingTransition`s.
`ConsensusEngine::epoch_verifier` is not used anywhere.
Constant propagate and remove is_epoch_end
foriequal0
force-pushed
the
feature/remove-epoch
branch
2 times, most recently
from
May 8, 2019 18:25
65a2fc5 to
ccd0c23
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch should not introduce breaking-change.
I'll check that by synchronizing with the testnet.
Resolve: #1507