Skip to content

Refactor Timer - #1077

Merged
mergify[bot] merged 10 commits into
CodeChain-io:masterfrom
foriequal0:feature/timer-refactor
Jan 15, 2019
Merged

Refactor Timer#1077
mergify[bot] merged 10 commits into
CodeChain-io:masterfrom
foriequal0:feature/timer-refactor

Conversation

@foriequal0

@foriequal0 foriequal0 commented Jan 9, 2019

Copy link
Copy Markdown
Contributor
  • TimerApi holds temporal mutable field. It was TimeoutHandler's role. TimerApi can be created without TimeoutHandler, and it can be set later.
    Resolves: Timer should embrace temporal mutability #1062
  • Resolve circular reference when TimeoutHandler holds TimerApi.
  • Add trace logs

@foriequal0
foriequal0 requested a review from sgkim126 January 9, 2019 18:51
sgkim126
sgkim126 reviewed Jan 10, 2019
View reviewed changes
Comment thread util/timer/src/timer.rs Resolved
sgkim126
sgkim126 reviewed Jan 10, 2019
View reviewed changes
Comment thread util/timer/src/timer.rs Resolved
sgkim126
sgkim126 reviewed Jan 10, 2019
View reviewed changes
Comment thread util/timer/src/timer.rs Resolved
sgkim126
sgkim126 reviewed Jan 10, 2019
View reviewed changes
Comment thread util/timer/src/timer.rs Resolved
@foriequal0
foriequal0 force-pushed the feature/timer-refactor branch 2 times, most recently from 2f9f3f2 to 02998d0 Compare January 10, 2019 06:31
@foriequal0 foriequal0 mentioned this pull request Jan 10, 2019
Merged
@foriequal0
foriequal0 force-pushed the feature/timer-refactor branch from 02998d0 to a17366b Compare January 10, 2019 06:38
@foriequal0

foriequal0 commented Jan 10, 2019

Copy link
Copy Markdown
Contributor Author

Resolved conflict with #1075

@sgkim126 sgkim126 removed the network label Jan 11, 2019
sgkim126
sgkim126 requested changes Jan 12, 2019
View reviewed changes
Comment thread util/timer/src/timer.rs Resolved
Comment thread util/timer/src/timer.rs Resolved
@foriequal0
foriequal0 force-pushed the feature/timer-refactor branch from a17366b to a9c691b Compare January 12, 2019 17:49
sgkim126
sgkim126 reviewed Jan 14, 2019
View reviewed changes
Comment thread util/timer/src/timer.rs Resolved
@foriequal0
foriequal0 force-pushed the feature/timer-refactor branch from a9c691b to 2102673 Compare January 15, 2019 02:49
@mergify
mergify Bot merged commit 39f21a3 into CodeChain-io:master Jan 15, 2019
@foriequal0 foriequal0 mentioned this pull request Jan 16, 2019
Closed
@foriequal0
foriequal0 deleted the feature/timer-refactor branch January 16, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgkim126 sgkim126 sgkim126 approved these changes

Assignees

No one assigned

Labels

refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@foriequal0 @sgkim126