Skip to content

Trigger RESEAL_MIN_TIMER when block is imported - #1041

Merged
mergify[bot] merged 5 commits into
CodeChain-io:masterfrom
majecty:f/trigger_reseal_min
Jan 7, 2019
Merged

mergify[bot] merged 5 commits into
CodeChain-io:masterfrom
majecty:f/trigger_reseal_min

Conversation

@majecty

@majecty majecty commented Jan 3, 2019

Copy link
Copy Markdown

No description provided.

Comment thread test/src/helper/promise.ts Resolved
@hyunsikjeong

hyunsikjeong commented Jan 4, 2019 •

Copy link
Copy Markdown
Contributor

@sgkim126 I'm not sure about triggering the reseal timer in chain_new_blocks(). Do you know when the transactions of new blocks are removed from the mempool? I think we need to trigger the timer when there are some transactions moved from the future pool to the current pool after importing new blocks.

@majecty
majecty force-pushed the f/trigger_reseal_min branch from 4134889 to 190fc7b Compare January 4, 2019 02:45
@sgkim126

sgkim126 commented Jan 4, 2019

Copy link
Copy Markdown
Contributor

@jhs7jhs AFAIK, they are removed on chain_new_blocks. chain_new_blocks is called right before calling Chain::new_blocks() in import_sealed_block and import_verified_block.
The future transactions are moved in remove_old method, but I'm not sure whether there is no other code path that moves future transactions.

@majecty
majecty force-pushed the f/trigger_reseal_min branch from 190fc7b to 5cfea43 Compare January 7, 2019 01:29
Comment thread test/src/helper/promise.ts Resolved
Juhyung Park added 3 commits January 7, 2019 15:49
The purpose of PromiseExpect is logging the async function which causes
timeout.
This fixes src/integration.long/futureTransaction.ts test
@majecty
majecty force-pushed the f/trigger_reseal_min branch from 5cfea43 to 3e0f8a8 Compare January 7, 2019 06:50
@mergify
mergify Bot merged commit f27845b into CodeChain-io:master Jan 7, 2019
@majecty
majecty deleted the f/trigger_reseal_min branch July 1, 2019 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants