Skip to content

Don't assume that valid proposal is always one in one round #1773

Closed

Description

@majecty

If a proposer double voted in one round, there could be two or more proposal blocks in the round.
One of the blocks could be finalized in the height.

Activity

  1. kseo commented on Sep 20, 2019

    @kseo
    Member

    @majecty what happens if there are two proposal blocks in one round?

  2. majecty commented on Sep 24, 2019

    @majecty
    Author

    I'm not sure what is the effect of it. I created this issue since the code depends on an invalid assumption.

  3. majecty commented on Sep 24, 2019

    @majecty
    Author

    If there are two proposal blocks in one round, the finalization time in a network disaster will be increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions