Skip to content

Change VoteCollector::vote to return Result<(), DoubleVote<M>> rather than Option<DoubleVote<M>> #1766

Closed
Closed
Change VoteCollector::vote to return Result<(), DoubleVote<M>> rather than Option<DoubleVote<M>>#1766
Labels
refactoring

Description

@foriequal0
foriequal0
opened on Sep 6, 2019

Rust can ensure Result<T, E> must be used while Option<T> doesn't. It'll prevent some classes of errors.

Activity

  1. kseo
    added
    refactoring
    on Sep 20, 2019

  2. seonpyoKim commented on Oct 18, 2019

    @seonpyoKim
    seonpyoKim
    on Oct 18, 2019
    Contributor

    Is this issue fully resolved with the pr #1800 or some other code is still remaining?

  3. foriequal0 commented on Oct 18, 2019

    @foriequal0
    foriequal0
    on Oct 18, 2019
    ContributorAuthor

    This issue is fully resolved with it. I'll close this.

  4. foriequal0
    closed this as completedon Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactoring

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions