Repository navigation
Restore transaction state when committing fails - #19
Merged
Merged
Conversation
This was referenced Oct 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 98.74% 98.77% +0.03%
==========================================
Files 1 1
Lines 159 163 +4
==========================================
+ Hits 157 161 +4
Misses 2 2 ☔ View full report in Codecov by Harness. |
Code0x58
force-pushed
the
codex/rollback-failed-commits
branch
from
October 18, 2026 15:13
e90570f to
29946db
Compare
Code0x58
force-pushed
the
codex/rollback-failed-commits
branch
4 times, most recently
from
October 18, 2026 15:46
d623c9f to
bc3b9ae
Compare
Code0x58
force-pushed
the
codex/rollback-failed-commits
branch
from
October 18, 2026 15:47
bc3b9ae to
e99a71f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the outermost transaction cannot save, its previous in-memory state is restored and the original exception propagates. The transaction stack is cleared correctly so a subsequent transaction can commit.
Validation: 35 tests pass, including nested changes followed by replacement failure with both auto-commit modes, recovery on retry, and interrupted commits.
Stack position 6 of 9. Depends on #18; this PR targets
codex/preserve-file-permissionsso its diff contains only this fix. Addresses review finding 6.Stack overview: #14. Next: #20.