Injecting scoped services as callee #8

Activity

1. darkl commented on Jan 4, 2017

   

   darkl

   on Jan 4, 2017

   Member

   More actions

   I'm not sure I understand your problem. What are you trying to achieve?

   Elad
2. kasravi commented on Jan 5, 2017

   

   kasravi

   on Jan 5, 2017

   Author

   More actions

   let me write some code (assume that ConfigureServices is called runtime at startup)

       public class RpcService
       {
           public static void ConfigureServices(IServiceCollection serviceCollection)
           {
               serviceCollection.AddTransient(typeof(RpcService));
           }
   
           public RpcServiceSubA _rpcServiceSubA;
           public UserInfo _userInfo;
   
           public RpcService(RpcServiceSubA rpcServiceSubA, UserInfo userInfo)
           {
               _rpcServiceSubA = rpcServiceSubA;
               _userInfo = userInfo;
           }
   
           [WampProcedure("ping")]
           public RpcService Ping()
           {
              return this;
           }
       }
   
      public class RpcServiceSubA
       {
           public static void ConfigureServices(IServiceCollection serviceCollection)
           {
               serviceCollection.AddTransient(typeof(RpcServiceSubA));
           }
   
           public UserInfo _userInfo;
   
           public RpcServiceSubA(UserInfo userInfo)
           {
               _userInfo = userInfo;
           }
       }
   
      public class UserInfo
       {
           public static void ConfigureServices(IServiceCollection serviceCollection)
           {
               serviceCollection.AddSingleton(typeof(UserInfo));
           }
           public Guid MyKey { get; } = Guid.NewGuid();
       }
   

   We then inject this service like this:

               ....
               using (IWampHost host = new DefaultWampHost(location))
               {
                    IWampHostedRealm realm = host.RealmContainer.GetRealmByName("realm1");
   
                   Task<IAsyncDisposable> registrationTask = realm.Services.RegisterCallee(()=>ServiceManager.GetRequiredService<RpcService>());
                   registrationTask.Wait();
   
                   host.Open();
   
               }
   

   In which the service manager is responsible for providing an instance for every call.
   Now consider if we register UserInfo as Singleton then we would have same MyKey in diffrent calls of ping:
   

   if we register it as Transient then we would have diffrent MyKeys since the service manager would new up an instance every time:
   

   These two are working as expected but if we add UserInfo as Scoped we expect that MyKeys would be same in every RPC call, since they are in different WampInvocationContext. something like this
   
   but the result as I said above is similar to Singleton. I'm trying to make scoped services also work where scopes are created before calls and disposed afterwards.
3. darkl commented on Jan 5, 2017

   

   darkl

   on Jan 5, 2017 via email

   Member

   More actions

   Cool. Does your DI support custom scopes?
4. kasravi commented on Jan 5, 2017

   

   kasravi

   on Jan 5, 2017

   Last edited by kasravi

   Author

   More actions

   I'm not sure about the definition of custom scope but if you mean something like here then no. we just have the Transient, Singleton and something like Request. (our DI is completely similar to .Net Core DI)
5. darkl commented on Jan 5, 2017

   

   darkl

   on Jan 5, 2017

   Member

   More actions

   That's a bummer, since with Ninject you could simply write:

   kernel.Bind<UserInfo>().ToSelf().InScope(x => WampInvocationContext.Current);
6. kasravi commented on Jan 5, 2017

   

   kasravi

   on Jan 5, 2017

   Author

   More actions

   aah, well one way for me is to see what is happening in Ninject's custom scopes and if I can add this kind of scopes to our framework. I will continue this thread if there is no easy way towards custom scopes. thanks!