Repository navigation
Conversation
The executor tests always ran in an Ubuntu 24.04 container. The Dockerfile now takes a BASE_IMAGE build argument, set from CODSPEED_TEST_BASE_IMAGE (default ubuntu:24.04), so the suite can run on other releases such as Ubuntu 26.04. Each base image gets its own image tags, setup container and target volume: binaries built against a newer glibc do not run on an older one, and the setup image cleanup no longer deletes another base's image. `just clean-integ` removes them all by name filter. CODSPEED_VALGRIND_BUILD_FROM_SOURCE is forwarded to the containers when set, so the valgrind source-build fallback can be controlled in the tests. Refs COD-3305 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merging this PR will not alter performance
|
Run the unit tests and the basic run test on ubuntu-24.04 and ubuntu-26.04 runners, each with its own Rust cache, and the executor tests on ubuntu:24.04 and ubuntu:26.04 base images. Set CODSPEED_VALGRIND_BUILD_FROM_SOURCE=false for the whole workflow, so a system we publish no valgrind package for fails instead of silently falling back to a source build. Until a 26.04 package is published, the simulation runs on 26.04 fail. Refs COD-3305 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ckage CODSPEED_VALGRIND_DEB=<path to a .deb> installs that valgrind-codspeed package, with libc6-dbg as `codspeed setup` does, in the setup container instead of the pinned release. This tests a package before it is published, e.g. one built for a new Ubuntu release. The package contents are hashed into the setup image tag, so a rebuilt package gets a fresh setup image. setup.sh now takes the valgrind-codspeed source as `commit <sha>` or `deb <path>`, and CODSPEED_VALGRIND_REF and CODSPEED_VALGRIND_DEB are mutually exclusive. Refs COD-3305 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lvaroqui
force-pushed
the
cod-3305-support-ubuntu-2604
branch
from
October 8, 2026 15:22
694b5ce to
3230d82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the CI on Ubuntu 26.04 alongside 24.04: the unit tests and the basic run test on
ubuntu-24.04andubuntu-26.04runners, and the executor tests onubuntu:24.04andubuntu:26.04base images.The executor tests run in Docker, so the Dockerfile now takes a
BASE_IMAGEbuild argument, set bytests/docker/run.shfromCODSPEED_TEST_BASE_IMAGE(defaultubuntu:24.04). Each base image gets its own image tags, setup container and target volume: binaries built against 26.04's glibc do not run in a 24.04 container, and the setup image cleanup would otherwise delete the other base's image.The workflow sets
CODSPEED_VALGRIND_BUILD_FROM_SOURCE=false(forwarded into the test containers), so a system we publish no valgrind package for fails instead of falling back to a source build that takes minutes and hides the missing package. No valgrind-codspeed package is published for 26.04 yet, so the simulation runs on 26.04 are expected to fail until it is: the 14 simulation executor tests and the wholebasic-run-test (ubuntu-26.04)job. Note thatcodspeed setuponly warns when valgrind cannot be installed, so the failure surfaces atcodspeed run, not at setup.With the fallback left on, the full executor suite passes locally on
ubuntu:26.04(valgrind-codspeed built from source, every shard green).Refs COD-3305, which stays open until valgrind-codspeed is published for 26.04.