Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
"prettier": "^3.3.2",
"rimraf": "^4.4.1",
"serve": "^14.0.0",
"storybook": "^10.2.10",
"storybook": "^10.6.2",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Storybook core moves to 10.6.2, but the @storybook/* framework, addons and eslint plugin stay on 10.1.4

storybook is bumped to ^10.6.2, but @storybook/nextjs, @storybook/addon-docs, @storybook/addon-links, @storybook/addon-themes (all ^10.1.4) and eslint-plugin-storybook (pinned 10.1.4) are unchanged. yarn.lock still resolves them, along with @storybook/react, @storybook/preset-react-webpack and @storybook/core-webpack, to 10.1.4. These packages import storybook/internal/* and are released in lockstep with core. Storybook's own version check and storybook doctor flag mismatches like this, and the mix can break storybook dev and storybook build. Their storybook: ^10.1.4 peer range accepts 10.6.2, so yarn won't warn. Fix: bump every @storybook/* 10.x package and eslint-plugin-storybook to 10.6.2 in this PR, for example with npx storybook@10.6.2 upgrade.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — Storybook core bumped to 10.6.2 while framework, addons and eslint plugin stay on 10.1.4

Bump @storybook/nextjs, @storybook/addon-docs, @storybook/addon-links, @storybook/addon-themes (lines 111-115) and eslint-plugin-storybook (line 138) to 10.6.2 in the same PR (e.g. npx storybook@10.6.2 upgrade), then regenerate yarn.lock. Today yarn.lock resolves storybook@10.6.2 next to @storybook/nextjs, @storybook/react, @storybook/builder-webpack5, @storybook/preset-react-webpack, @storybook/csf-plugin and @storybook/react-dom-shim at 10.1.4 (yarn.lock ~10781-11040). Storybook expects every @storybook/* package to run the same version as core. The 10.1.4 framework and builder import storybook/internal/* from 10.6.2, which only works if those internals did not change across five minor releases. The ^10.1.4 peer ranges let yarn accept this mix without complaint, and storybook doctor flags it as a version mismatch.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

"stylelint": "^16.26.1",
"stylelint-config-standard-scss": "^16.0.0",
"stylelint-prettier": "^5.0.3",
Expand Down
Loading
Loading