Repository navigation
feat: use SeverityNumber for log levels in the UI #3427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@hyperdx/common-utils': minor | ||
| --- | ||
|
|
||
| Add `core/severity` with the OpenTelemetry log severity rules: | ||
| `getSeverityClass` (from SeverityNumber 1-24, falling back to a case-insensitive | ||
| severity text prefix), `getSeverityShortName` and `getSeverityLabel`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| '@hyperdx/app': patch | ||
| --- | ||
|
|
||
| When a log source sets Severity Number Expression, log levels follow the | ||
| OpenTelemetry SeverityNumber (1-24) in the row side panel, the search results | ||
| and pattern table level cells, the pattern trend bars, and the trace waterfall's | ||
| log error and warning flags. Levels show the spec's short name, such as `INFO2`, | ||
| add the stored text in parentheses when it differs, as in | ||
| `INFO (Informational)`, and take their color from the number. The search results | ||
| and pattern table use the number only when the expression names a stored numeric | ||
| column. Copy and filter actions still use the stored text. Rows without a number | ||
| in 1-24, and sources without the field, show the stored text as before. Level | ||
| labels and the waterfall flags also treat `panic`, `dpanic`, `ftl` and `severe` | ||
| as errors and `wrn` as a warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 minor — Side panel row query selects severityNumberExpression with no check, so a bad expression breaks the whole panel
The search table selects the number only for a stored numeric column ('the number isn't worth failing a query over' per getSelectableSeverityNumberExpression). The side panel's full-row query adds the raw expression unconditionally. A missing column or bad expression (e.g. a column dropped from the table) now fails the row fetch, which blanks the whole side panel just to color one badge. Use the same column check as
getSeverityNumberSelect, or fetch the number in a separate query whose failure doesn't affect the row.Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond