Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/row-panel-source-query-settings.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@hyperdx/app': patch
---

fix: Apply source query settings to the row side panel's row lookup
1 change: 1 addition & 0 deletions packages/app/src/components/DBRowDataPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export function useRowData({
: undefined;

const baseConfig = {
source: source.id,
connection: source.connection,
select: [
{
Expand Down
16 changes: 16 additions & 0 deletions packages/app/src/components/__tests__/DBRowDataPanel.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,22 @@ describe('DBRowDataPanel', () => {
});
});

// useQueriedChartConfig resolves the source's querySettings from config.source
it('passes the source id on both the bounded and fallback lookups', () => {
renderHook(() =>
useRowData({
source,
rowId: "id='abc123'",
dateRange: [new Date(0), new Date(1000)],
}),
);

expect(mockUseQueriedChartConfig).toHaveBeenCalledTimes(2);
for (const [config] of mockUseQueriedChartConfig.mock.calls) {
expect(config.source).toBe('source-id');
}
});

it('selects `*` when the source has no Known Columns List', () => {
renderHook(() => useRowData({ source, rowId: "id='abc123'" }));

Expand Down
Loading