[HDX-5307] Drop the search bar WHERE label and / keycap by elizabetdev · Pull Request #3168 · ClickHouse/ClickStack

elizabetdev · 2026-09-21T10:09:38Z

Summary

Drop the redundant WHERE label and the / keycap overlay from the search bar.
/ and s still focus the input.
Re-opened against main after [HDX-5307] Drop the search bar WHERE label and / keycap #3152 merged into the stacked base branch instead of main ([HDX-5307] Keep multi-line query fields visible when unfocused #3150 had already landed).

Test plan

Empty SQL bar shows the placeholder and no WHERE label.
/ and s still focus the input with no keycap overlay.

The label repeated the SQL placeholder, and the overlay clipped long queries. Keyboard shortcuts still focus the input. Co-authored-by: Cursor <cursoragent@cursor.com>

changeset-bot · 2026-09-21T10:09:44Z

🦋 Changeset detected

Latest commit: 0f5dd8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@hyperdx/app	Patch
@hyperdx/api	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-09-21T10:09:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
hyperdx-oss	Ready	Preview	Sep 21, 2026 12:11pm UTC
hyperdx-storybook	Ready	Preview	Sep 21, 2026 12:11pm UTC

github-actions · 2026-09-21T10:10:02Z

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats

Production files changed: 10
Production lines changed: 59 (+ 40 in test files, excluded from tier calculation)
Branch: elizabet/hdx-5307-search-bar-chrome
Author: elizabetdev

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

greptile-apps · 2026-09-21T10:12:35Z

Confidence Score: 5/5

The PR appears safe to merge; the only outstanding feedback is a non-blocking missing regression assertion for the removed WHERE label.

Findings

Missing label regression check ▶

Summary

This PR removes the SQL WHERE label and shortcut keycap while preserving search-focus hotkeys. It also top-aligns controls beside query editors that can grow onto multiple lines and adds optional padding for the growing Sessions toolbar.

Removes obsolete label-related props and call-site overrides.
Removes the visual / keycap without changing keyboard focus behavior.
Updates stories, tests, toolbar alignment, and release changesets.
The previous review’s request for an explicit negative assertion that WHERE is absent remains outstanding.

_{Reviews (2) · Last reviewed commit: "Merge branch 'main' into elizabet/hdx-53..."}

greptile-apps · 2026-09-21T10:12:39Z

+    it('renders the SQL editor when whereLanguage is sql', () => {
      renderWithMantine(<TestWrapper defaultLanguage="sql" />);

-      expect(screen.getByText('WHERE')).toBeInTheDocument();
+      expect(
+        screen.getByRole('combobox', { name: 'Query language' }),
+      ).toHaveValue('SQL');
+      expect(
+        screen.queryByPlaceholderText(/Search your events w\/ Lucene/i),
+      ).not.toBeInTheDocument();


Missing label regression check

The rewritten SQL-mode test confirms that the SQL editor renders, but it no longer checks the behavior this PR changes: that the WHERE label is absent. Add a negative assertion for the label so a future regression cannot reintroduce it unnoticed.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

github-actions · 2026-09-21T10:13:43Z


  describe('SQL Mode', () => {
-    it('renders SQL input with WHERE label when whereLanguage is sql', () => {
+    it('renders the SQL editor when whereLanguage is sql', () => {


🔵 minor — The renamed SQL-mode test no longer pins the removal of the WHERE label

The two assertions that covered the label (getByText('WHERE') here, and the deleted hides label when showLabel is false case) were replaced with checks on the language select's value and the absence of the Lucene placeholder — neither relates to this change, and the next test (renders SQL placeholder) already proves the SQL editor rendered. Restoring label="WHERE" on the SQLInlineEditorControlled in SearchWhereInput.tsx:229 would keep every test green, because the only new assertion about removed chrome (container.querySelector('kbd'), line 92) lives in the Lucene test while the label was SQL-only. Add expect(screen.queryByText('WHERE')).not.toBeInTheDocument() to this SQL-mode test, and move (or duplicate) the kbd assertion into SQL mode as well since the keycap rendered in both languages.

_{Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond}

github-actions · 2026-09-21T10:13:44Z

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.

🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.

Anything about surrounding code, or asking you to widen the change (hoist a helper,
dedupe with another file, fix other call sites): never fix here, whatever the
severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

1 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 1 minor

1 posted as inline comment(s) on the changed lines.

_{Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.}

github-actions · 2026-09-21T10:13:52Z

Deep Review

This PR removes the WHERE label and the / keycap overlay from the shared SearchWhereInput component, drops the now-unused showLabel/label props, and updates every in-repo caller, the Storybook stories, the tests, and a changeset. All call sites that passed the removed props are updated in the same diff, so the prop-type removal is internally consistent and would fail compilation if a caller were missed. The change is cosmetic UI chrome with no data, auth, or contract impact; keyboard focus via / and s is preserved by the untouched enableHotkey handlers.

🟡 P2 -- recommended

packages/app/src/components/SearchInput/__tests__/SearchWhereInput.test.tsx:142 -- The rewritten SQL-mode test asserts the SQL editor renders but no longer asserts the WHERE label is absent, so a regression that reintroduces the label would pass unnoticed; this is the exact behavior the PR ships and its guard was deleted with the old hides label when showLabel is false test.
- Fix: Add expect(screen.queryByText('WHERE')).not.toBeInTheDocument(); to the renders the SQL editor when whereLanguage is sql test.
- _{ce-testing-reviewer, ce-previous-comments-reviewer}

🔵 P3 nitpicks (1)

packages/app/src/components/SearchInput/__tests__/SearchWhereInput.test.tsx:88 -- The removed / keycap overlay is only asserted absent in the Lucene-mode test; since the keycap rendered mode-agnostically (gated only on enableHotkey), Lucene coverage is functionally adequate but no test confirms its absence in SQL mode.
- Fix: Add a container.querySelector('kbd') absence assertion to the SQL-mode test for symmetric coverage.

Reviewers (9): ce-correctness-reviewer, ce-testing-reviewer, ce-maintainability-reviewer, ce-project-standards-reviewer, ce-kieran-typescript-reviewer, ce-api-contract-reviewer, ce-agent-native-reviewer, ce-learnings-researcher, ce-previous-comments-reviewer.

Testing gaps: The keycap-absence check runs only with enableHotkey=true; the enableHotkey-false path (no keycap ever rendered) is not exercised, though its risk is negligible.

_{No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond}

github-actions · 2026-09-21T10:18:44Z

E2E Test Results

✅ All tests passed • 377 passed • 1 skipped • 1154s

Status	Count
✅ Passed	377
❌ Failed	0
⚠️ Flaky	2
⏭️ Skipped	1

Tests ran across 4 shards in parallel.

View full report →

github-actions · 2026-09-21T12:12:03Z

      );
      expect(input).toBeInTheDocument();
+      // `/` and `s` still focus the input; the overlay keycap is gone.
+      expect(container.querySelector('kbd')).not.toBeInTheDocument();


🔵 minor — The new assertion pins the keycap's absence, not the hotkey the PR claims still works

expect(container.querySelector('kbd')).not.toBeInTheDocument() is an absence proxy, and the comment beside it ("/ and s still focus the input") is the one thing nothing checks — a grep for press('/')/keyboard('/')/hotkey across packages/app/tests and the jest suites returns nothing, so deleting the useHotkeys(['/', 's'], …) call in SearchInputV2.tsx:128 or SQLEditor/SQLInlineEditor.tsx:228 keeps every test green while breaking the behaviour the changeset promises. Add a case that renders with enableHotkey, fires / on document.body, and asserts the Lucene textarea (and the SQL .cm-content) has focus.

_{Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond}

fix(app): drop the search bar WHERE label and / keycap

f784e3d

The label repeated the SQL placeholder, and the overlay clipped long queries. Keyboard shortcuts still focus the input. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Sep 21, 2026

greptile-apps Bot reviewed Sep 21, 2026

View reviewed changes

vercel Bot deployed to Preview – hyperdx-storybook September 21, 2026 10:12

View deployment

github-actions Bot reviewed Sep 21, 2026

View reviewed changes

vercel Bot deployed to Preview – hyperdx-oss September 21, 2026 10:15

View deployment

pulpdrew approved these changes Sep 21, 2026

View reviewed changes

Merge branch 'main' into elizabet/hdx-5307-search-bar-chrome

0f5dd8e

elizabetdev added the automerge label Sep 21, 2026

vercel Bot deployed to Preview – hyperdx-storybook September 21, 2026 12:11

View deployment

vercel Bot deployed to Preview – hyperdx-oss September 21, 2026 12:11

View deployment

github-actions Bot reviewed Sep 21, 2026

View reviewed changes

kodiakhq Bot merged commit 4c4792f into main Sep 21, 2026
28 checks passed

kodiakhq Bot deleted the elizabet/hdx-5307-search-bar-chrome branch September 21, 2026 12:15

Navigation Menu

Repository navigation

[HDX-5307] Drop the search bar WHERE label and / keycap - #3168

[HDX-5307] Drop the search bar WHERE label and / keycap#3168
kodiakhq[bot] merged 2 commits into
mainfrom
elizabet/hdx-5307-search-bar-chrome

elizabetdev commented Sep 21, 2026

Uh oh!

changeset-bot Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 21, 2026

Uh oh!

greptile-apps Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Sep 21, 2026

Uh oh!

github-actions Bot Sep 21, 2026

Uh oh!

github-actions Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot Sep 21, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

elizabetdev commented Sep 21, 2026

Summary

Test plan

Uh oh!

changeset-bot Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 21, 2026

🔵 Tier 2 — Low Risk

Uh oh!

greptile-apps Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Findings

Summary

Uh oh!

greptile-apps Bot Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

github-actions Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deep Review

🟡 P2 -- recommended

Uh oh!

github-actions Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Results

Uh oh!

github-actions Bot Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Sep 21, 2026 •

edited

Loading

vercel Bot commented Sep 21, 2026 •

edited

Loading

greptile-apps Bot commented Sep 21, 2026 •

edited

Loading

github-actions Bot commented Sep 21, 2026 •

edited

Loading

github-actions Bot commented Sep 21, 2026 •

edited

Loading

github-actions Bot commented Sep 21, 2026 •

edited

Loading