Skip to content

feat: improve query setting validation #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fleon merged 1 commit into from
Jan 23, 2026
Merged

feat: improve query setting validation #1648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/api/src/models/source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,10 @@ export const Source = mongoose.model<ISource>(
querySettings: {
type: [
{
setting: { type: String, required: true },
value: { type: String, required: true },
setting: { type: String, required: true, minlength: 1 },
value: { type: String, required: true, minlength: 1 },
},
],
default: undefined,
maxlength: 10,
},
},
Expand Down
7 changes: 1 addition & 6 deletions packages/app/src/hooks/useChartConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {
ResponseJSON,
} from '@hyperdx/common-utils/dist/clickhouse';
import { ClickhouseClient } from '@hyperdx/common-utils/dist/clickhouse/browser';
import { tryOptimizeConfigWithMaterializedView } from '@hyperdx/common-utils/dist/core/materializedViews';
import { Metadata } from '@hyperdx/common-utils/dist/core/metadata';
import {
isMetricChartConfig,
Expand Down Expand Up @@ -397,10 +396,6 @@ export function useAliasMapFromChartConfig(

const metadata = useMetadataWithSettings();

const { data: source, isLoading: isSourceLoading } = useSource({
id: config?.source,
});

return useQuery<Record<string, string>>({
// Only include config properties that affect SELECT structure and aliases.
// When adding new ChartConfig fields, check renderChartConfig.ts to see if they
Expand Down Expand Up @@ -432,7 +427,7 @@ export function useAliasMapFromChartConfig(

return aliasMap;
},
enabled: config != null && !isSourceLoading,
enabled: config != null,
...options,
});
}
2 changes: 1 addition & 1 deletion packages/common-utils/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ export enum SourceKind {
// --------------------------

const QuerySettingsSchema = z.array(
z.object({ setting: z.string(), value: z.string() }),
z.object({ setting: z.string().min(1), value: z.string().min(1) }),
);

export type QuerySettings = z.infer<typeof QuerySettingsSchema>;
Expand Down
Loading