Skip to content

feat: Add dashboard tile tags for organization and filtering - #1568

Closed
alok87 wants to merge 10 commits into
ClickHouse:mainfrom
alok87:fix-1558-dashboard-label-view
Closed

feat: Add dashboard tile tags for organization and filtering#1568
alok87 wants to merge 10 commits into
ClickHouse:mainfrom
alok87:fix-1558-dashboard-label-view

Conversation

@alok87

@alok87 alok87 commented Jan 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

This PR implements dashboard tile tags feature as part of #1558.

Note: This PR builds on top of #1572 (Chart Legend Series Filtering). Please merge #1572 first.

Features

Dashboard Tile Tags & Filtering

  • Added tags field to dashboard tiles for organization
  • Tiles can be tagged in the edit modal
  • Click on tile tags to filter the dashboard view to show only tiles with that tag
  • Visual filter indicator shows active tag filter
  • URL state preservation for sharing filtered views

How It Works

  • Edit a tile and add tags in the "Tile Tags" section
  • Tags appear as badges on the tile
  • Click any tag to filter the dashboard to show only tiles with that tag
  • Click the close button on the filter indicator to clear the filter

Technical Changes

  • Updated TileSchema in common-utils to include optional tags field
  • Modified DBDashboardPage to support tag filtering with URL state
  • Added tag editor in the tile edit modal
  • Implemented clickable tag badges with filter toggle

Part of #1558

@changeset-bot

changeset-bot Bot commented Jan 7, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 329e833

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Minor
@hyperdx/common-utils Minor
@hyperdx/api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jan 7, 2026

Copy link
Copy Markdown

@alok87 is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

@brandon-pereira
brandon-pereira self-requested a review January 7, 2026 17:57
@alok87

alok87 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

Some bug - fixing.

@alok87

alok87 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

Fixed. Updated Video and Image also.

@alok87 alok87 mentioned this pull request Jan 7, 2026
Open
brandon-pereira
brandon-pereira reviewed Jan 7, 2026
View reviewed changes
Comment thread packages/app/src/dashboard.ts
@@ -20,6 +20,7 @@ export type Tile = {
w: number;
h: number;
config: SavedChartConfig;
tags?: string[];

@brandon-pereira brandon-pereira Jan 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alok87 can we separate these PRs so there are two? One for the DBTimeChart legend feature, and one for the dashboard tile tags? These feel like separate concerns.

Additionally, is it possible to run yarn changeset to generate a changeset for the two features?

@alok87 alok87 Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! ✅ I've split this PR into two separate PRs:

PR #1572: Chart Legend Series Filtering (Merge First)
#1572

  • Chart legend series filtering feature
  • Changes to HDXMultiSeriesTimeChart.tsx and DBTimeChart.tsx

PR #1568: Dashboard Tile Tags (This PR - Merge Second)

The PRs are now separated by concern and can be reviewed/merged independently. Will add changesets next!

@alok87
alok87 force-pushed the fix-1558-dashboard-label-view branch from ba87e00 to 5b53316 Compare January 8, 2026 03:59
@alok87 alok87 changed the title feat: Add dashboard tile tags and chart legend series filtering feat: Add dashboard tile tags for organization and filtering Jan 8, 2026
alok87 added 4 commits January 8, 2026 09:57
@alok87
feat: Add chart legend series filtering
519acc2 
- Click on legend labels to show only that series in the chart
- Shift+Click to select multiple series for comparison
- All legend items remain visible with clear visual feedback:
  - Selected: Bold font, thick line, full opacity
  - Non-selected: Dimmed (30% opacity) but still visible
- Click selected item again to clear filter and show all series
- Auto-scale Y-axis when filtering chart series to fit visible data

Part of ClickHouse#1558
@alok87
chore: Add changeset for chart legend series filtering
f54c250
@alok87
feat: Add dashboard tile tags for organization and filtering
326d5dd 
- Add tags field to dashboard tiles for better organization
- Tiles can be tagged in the edit modal
- Click on tile tags to filter the dashboard view
- Visual filter indicator shows active tag filter
- URL state preservation for sharing filtered views

Part of ClickHouse#1558
@alok87
chore: Add changeset for dashboard tile tags
7919268
@alok87
alok87 force-pushed the fix-1558-dashboard-label-view branch from 656f30c to 7919268 Compare January 8, 2026 05:08
@alok87

alok87 commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

This is not working, could not give more time but @brandon-pereira do evaluate if it can be brought in, as suppose in my dashboards i have many tiles and they have tags, if i click on some tag during troubleshooting all my tiles disappears and only those tag tiles remain. Please take this forward if you folks align.

@alok87

alok87 commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

@claude can we ask the matinier to take this forward?

@github-actions github-actions Bot added the review/tier-4 Critical — deep review + domain expert sign-off label Apr 6, 2026
@github-actions

github-actions Bot commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🟡 Tier 3 — Standard

Introduces new logic, modifies core functionality, or touches areas with non-trivial risk.

Why this tier:

  • Cross-layer change: touches frontend (packages/app) + shared utils (packages/common-utils)

Review process: Full human review — logic, architecture, edge cases.
SLA: First-pass feedback within 1 business day.

Stats
  • Production files changed: 5
  • Production lines changed: 534
  • Branch: fix-1558-dashboard-label-view
  • Author: alok87

To override this classification, remove the review/tier-3 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions github-actions Bot added review/tier-3 Standard — full human review required and removed review/tier-4 Critical — deep review + domain expert sign-off labels Apr 6, 2026
@pulpdrew

pulpdrew commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

This has been dormant for a while, and features like dashboard containers and tabs have been added to support improved dashboard organization, so I will close this for now. Feel free to re-open an issue if we need to revisit this. Thanks for your interest in contributing @alok87!

@pulpdrew pulpdrew closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandon-pereira brandon-pereira brandon-pereira left review comments

Assignees

No one assigned

Labels

review/tier-3 Standard — full human review required waiting-on-author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alok87 @pulpdrew @brandon-pereira