MCP: PromQL, dashboard-tile, pattern and describe_source tools return no cost statistics #3649

// Repro: which MCP query tools return ClickHouse cost statistics (elapsed, rows_read, bytes_read).
// Copy to packages/api/src/mcp/__tests__/dashboards/ and run:
//   make dev-int FILE=reproToolStatistics
import { DisplayType, SourceKind } from '@hyperdx/common-utils/dist/types';

import {
  bulkInsertLogs,
  DEFAULT_DATABASE,
  DEFAULT_LOGS_TABLE,
  dropTimeSeriesTable,
  seedTimeSeriesTagsTable,
} from '@/fixtures';
import { callTool, getFirstText } from '@/mcp/__tests__/mcpTestUtils';
import Dashboard from '@/models/dashboard';
import { Source } from '@/models/source';

import { setupDashboardTests } from './setup';

const mockFetch = jest.mocked(global.fetch);
const realFetch: typeof fetch = globalThis.realFetch;

const TABLE = 'repro_tool_statistics';

/** Every value under a key named `statistics`, anywhere in the response. */
const findStatistics = (node: unknown): unknown[] =>
  node == null || typeof node !== 'object'
    ? []
    : Object.entries(node).flatMap(([k, v]) =>
        k === 'statistics' ? [v] : findStatistics(v),
      );

describe('repro: cost statistics per MCP tool', () => {
  const ctx = setupDashboardTests();
  const now = Date.now();
  const start = new Date(now - 30 * 60_000).toISOString();
  const end = new Date(now + 60_000).toISOString();

  beforeAll(async () => {
    const nowSec = Math.floor(now / 1000);
    await seedTimeSeriesTagsTable({
      table: TABLE,
      series: ['a', 'b'].map(pod => ({
        metricName: 'repro_up',
        tags: { job: 'api', pod },
        startSec: nowSec - 1200,
        endSec: nowSec - 60,
      })),
      withSamples: true,
    });
  });
  afterAll(() => dropTimeSeriesTable({ table: TABLE }));

  it('prints which tools return statistics', async () => {
    await ctx.reconnect({ promqlEnabled: true });
    mockFetch.mockImplementation(realFetch);
    await bulkInsertLogs(
      Array.from({ length: 50 }, (_, i) => ({
        Body: `request ${i % 5} failed after ${i} ms`,
        ServiceName: 'api',
        SeverityText: i % 2 ? 'ERROR' : 'INFO',
        Timestamp: new Date(now - (i % 20) * 60_000),
      })),
    );
    const logSource = await Source.create({
      kind: SourceKind.Log,
      team: ctx.team._id,
      from: { databaseName: DEFAULT_DATABASE, tableName: DEFAULT_LOGS_TABLE },
      timestampValueExpression: 'Timestamp',
      connection: ctx.connection._id,
      name: 'Logs',
      bodyExpression: 'Body',
      severityTextExpression: 'SeverityText',
    });
    const promSource = await Source.create({
      kind: SourceKind.Promql,
      team: ctx.team._id,
      connection: ctx.connection._id,
      name: 'Metrics',
      from: { databaseName: DEFAULT_DATABASE, tableName: TABLE },
      timestampValueExpression: 'timestamp',
    });
    const tile = (id: string, config: Record<string, unknown>) => ({ id, x: 0, y: 0, w: 6, h: 3, config });
    const dashboard = await new Dashboard({
      name: 'Repro',
      tiles: [
        tile('promql', {
          configType: 'promql',
          name: 'Up by pod',
          displayType: DisplayType.Line,
          source: promSource._id.toString(),
          granularity: '1 minute',
          promqlExpression: [{ expression: 'sum by (pod) (repro_up)' }],
        }),
        tile('builder', {
          name: 'Log lines',
          displayType: DisplayType.Line,
          source: logSource._id.toString(),
          select: [{ aggFn: 'count', valueExpression: '' }],
          where: '',
          granularity: '1 minute',
        }),
      ],
      filters: [],
      team: ctx.team._id,
    }).save();
    const logId = logSource._id.toString();
    const promId = promSource._id.toString();
    const dashboardId = dashboard._id.toString();

    const calls: [string, Record<string, unknown>][] = [
      ['clickstack_table', { sourceId: logId, select: [{ aggFn: 'count' }], groupBy: 'SeverityText', startTime: start, endTime: end }],
      ['clickstack_timeseries', { sourceId: logId, select: [{ aggFn: 'count' }], startTime: start, endTime: end }],
      ['clickstack_sql', { connectionId: ctx.connection._id.toString(), sql: `SELECT count() FROM ${DEFAULT_DATABASE}.${DEFAULT_LOGS_TABLE}`, startTime: start, endTime: end }],
      ['clickstack_query_tile', { dashboardId, tileId: 'builder', startTime: start, endTime: end }],
      ['clickstack_query_tile', { dashboardId, tileId: 'promql', startTime: start, endTime: end }],
      ['clickstack_promql', { sourceId: promId, expression: 'sum by (pod) (repro_up)', startTime: start, endTime: end }],
      ['clickstack_query_tiles', { dashboardId, startTime: start, endTime: end }],
      ['clickstack_event_patterns', { sourceId: logId, startTime: start, endTime: end }],
      ['clickstack_emerging_signals', {
        sourceId: logId,
        baselineStartTime: new Date(now - 30 * 60_000).toISOString(),
        baselineEndTime: new Date(now - 10 * 60_000).toISOString(),
        currentStartTime: new Date(now - 10 * 60_000).toISOString(),
        currentEndTime: end,
      }],
      ['clickstack_describe_source', { sourceId: logId }],
      ['clickstack_describe_source', { sourceId: promId }],
    ];

    const lines: string[] = [];
    const has: Record<string, boolean> = {};
    for (const [tool, args] of calls) {
      const result = await callTool(ctx.client!, tool, args);
      const text = getFirstText(result);
      let stats: unknown[] = [];
      try {
        stats = findStatistics(JSON.parse(text));
      } catch {
        // not JSON
      }
      const label = `${tool}${args.tileId ? ` (${args.tileId} tile)` : ''}${tool === 'clickstack_describe_source' ? (args.sourceId === promId ? ' (promql source)' : ' (log source)') : ''}`;
      has[label] = stats.length > 0;
      lines.push(
        `${label.padEnd(48)} ${result.isError ? 'ERROR ' : 'ok    '} statistics: ${stats.length ? JSON.stringify(stats[0]) : 'none'}`,
      );
    }
    console.log(`REPRO\n${lines.join('\n')}`);

    expect(has['clickstack_table']).toBe(true);
    expect(has['clickstack_query_tile (builder tile)']).toBe(true);
    for (const label of [
      'clickstack_promql',
      'clickstack_query_tile (promql tile)',
      'clickstack_query_tiles',
      'clickstack_event_patterns',
      'clickstack_emerging_signals',
      'clickstack_describe_source (log source)',
      'clickstack_describe_source (promql source)',
    ]) {
      expect([label, has[label]]).toEqual([label, false]);
    }
  });
});