Skip to content

-Wtautological-constant-compare in drivers/media/pci/ #752

New issue
New issue
Closed
Closed
-Wtautological-constant-compare in drivers/media/pci/#752
Assignees
nathanchance
Labels
-Wtautological-compare-Wtautological-constant-compare[BUG] linuxA bug that should be fixed in the mainline kernel.[FIXED][LINUX] 5.6This bug was fixed in Linux 5.6

Description

@nathanchance
nathanchance
opened on Oct 24, 2019

Meta: #488

Example:

drivers/media/pci/cx18/cx18-driver.c:1005:21: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
                        cx18_call_hw(cx, CX18_HW_GPIO_RESET_CTRL,
                                         ^
drivers/media/pci/cx18/cx18-cards.h:18:37: note: expanded from macro 'CX18_HW_GPIO_RESET_CTRL'
#define CX18_HW_GPIO_RESET_CTRL         (1 << 6)
                                           ^
1 warning generated.

Patch submitted: https://lore.kernel.org/lkml/20191024201240.49063-1-natechancellor@gmail.com/

Activity

  1. nathanchance
    added
    [BUG] linuxA bug that should be fixed in the mainline kernel.
    [PATCH] SubmittedA patch has been submitted for review
    -Wtautological-constant-compare
    on Oct 24, 2019
  2. nathanchance
    self-assigned this
    on Oct 24, 2019
  3. fengguang
    added a commit that references this issue on Oct 27, 2019

    media: v4l2-device.h: Explicitly compare grpmask to zero in v4l2_devi…

    a6f5e5d

  4. nathanchance commented on Dec 8, 2019

    @nathanchance
    nathanchance
    on Dec 8, 2019
    MemberAuthor

    v3: https://lore.kernel.org/lkml/20191208211139.18514-1-natechancellor@gmail.com/

  5. nickdesaulniers
    added
    [PATCH] AcceptedA submitted patch has been accepted upstream
    and removed
    [PATCH] SubmittedA patch has been submitted for review
    on Dec 16, 2019

  6. nathanchance commented on Dec 16, 2019

    @nathanchance
    nathanchance
    on Dec 16, 2019
    MemberAuthor

    https://git.linuxtv.org/media_tree.git/commit/?id=afb34781620274236bd9fc9246e22f6963ef5262

  7. ruscur
    added a commit that references this issue on Dec 17, 2019

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    afb3478

  8. nathanchance commented on Jan 31, 2020

    @nathanchance
    nathanchance
    on Jan 31, 2020
    MemberAuthor

    Merged into mainline: https://git.kernel.org/torvalds/c/afb34781620274236bd9fc9246e22f6963ef5262

  9. nathanchance
    closed this as completedon Jan 31, 2020
  10. nathanchance
    added
    [FIXED][LINUX] 5.6This bug was fixed in Linux 5.6
    and removed
    [PATCH] AcceptedA submitted patch has been accepted upstream
    on Jan 31, 2020
  11. Boos4721
    added a commit that references this issue on Feb 23, 2020

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    bdaa1a6

  12. 85 remaining items

  13. Huawei-Dev
    added a commit that references this issue on May 19, 2024

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    dfd1ef3
  14. Frostleaft07
    added a commit that references this issue on Jul 2, 2024

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    ef0f92a
  15. Andrey0800770
    added a commit that references this issue on Dec 21, 2024

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    9bb0f56
  16. Huawei-Dev
    added 2 commits that reference this issue on Jan 18, 2025

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    742f60c

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    3ba7315
  17. Huawei-Dev
    added 2 commits that reference this issue on Jul 14, 2025

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    72ff778

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    75c4891
  18. yunmo2007
    added a commit that references this issue on Apr 2, 2026

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    8eadf83
  19. yunmo2007
    added a commit that references this issue on Apr 19, 2026

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    714d455
  20. michael-dev
    added a commit that references this issue on Apr 25, 2026

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    e87f65a
  21. fkjbvfdvbnfdkjvbjfhd
    added a commit that references this issue on May 18, 2026

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    6630a80
  22. Huawei-Dev
    added a commit that references this issue on Jun 9, 2026

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    bfbc6d2
  23. nekoshirro
    added a commit that references this issue on Jun 14, 2026

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    d3921b4
  24. Huawei-Dev
    added a commit that references this issue on Jun 25, 2026

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    6dbecc0
  25. Youffx
    added a commit that references this issue on Jul 15, 2026

    media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2…

    21d1dc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

-Wtautological-compare-Wtautological-constant-compare[BUG] linuxA bug that should be fixed in the mainline kernel.[FIXED][LINUX] 5.6This bug was fixed in Linux 5.6

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions