This repository was archived by the owner on Apr 17, 2019. It is now read-only.
Repository navigation
Add a new option, queryKeepsLimits defines if the LIMITs should stay - #275
Merged
Merged
Conversation
When exporting a query using the QueryEngine, by default the current behaviour is to run the limit and skip functions on the QueryBuilder. Sometimes this may be the behaviour that you want. The default behaviour however should be to get the query without any limit or skips. A new option is introduced to make sure that the limits are the same as they were previously (where the query is the same as what is shown in the datatable). I will write a wiki article a little later showing a potential new use & implementation of this new functionality, which will allow server-side CSV exports ala TableTools (but for larger data).
Collaborator
Author
|
Hey, @Chumper. Is there anything wrong with this patch, anything that needs fixing up etc? |
Chumper
pushed a commit
that referenced
this pull request
Apr 7, 2015
Add a new option, queryKeepsLimits defines if the LIMITs should stay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exporting a query using the QueryEngine, by default the current
behaviour is to run the limit and skip functions on the QueryBuilder.
Sometimes this may be the behaviour that you want.
The default behaviour however should be to get the query without any
limit or skips. A new option is introduced to make sure that the limits
are the same as they were previously (where the query is the same as
what is shown in the datatable).
I will write a wiki article a little later showing a potential new use &
implementation of this new functionality, which will allow server-side
CSV exports ala TableTools (but for larger data).
(Closes #272, this is an updated branch after PR #267)