Skip to content

fix: restore registerDecls on Zig 0.16 - #59

Merged
GrapeBaBa merged 1 commit into
mainfrom
fix/register-decls-zig-0.16
Jul 24, 2026
Merged

GrapeBaBa merged 1 commit into
mainfrom
fix/register-decls-zig-0.16

Conversation

@GrapeBaBa

@GrapeBaBa GrapeBaBa commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

registerDecls is publicly exported, but consumers cannot instantiate it on Zig 0.16. Its implementation declares a type return without returning a type, uses obsolete type-info tags, and still calls the pre-CallbackInfo(argc) function APIs. The string branch also exits module initialization before assigning the export.

Description

  • Return void to match the registration side effect.
  • Update type-info tags and callback construction for Zig 0.16 and the current createFunction API.
  • Preserve the existing behavior of the options parameter.
  • Register string declaration values before continuing through the remaining exports.
  • Add a Node addon fixture and Vitest coverage for function and string declarations.

Comment thread src/register_decls.zig

pub fn registerDecls(comptime decls: anytype, comptime options: anytype) type {
pub fn registerDecls(comptime decls: anytype, comptime options: anytype) void {
_ = options;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not swallow the options. #61

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, noticed this, prefer a separate PR for this fix

@GrapeBaBa
GrapeBaBa merged commit 7f3af3e into main Jul 24, 2026
6 checks passed
nazarhussain pushed a commit that referenced this pull request Aug 18, 2026
🤖 I have created a release *beep* *boop*
---


##
[4.0.0](zapi-v3.1.0...zapi-v4.0.0)
(2026-08-18)


### ⚠ BREAKING CHANGES

* isolate DSL class tags across addons
([#67](#67))
* manage external buffer lifetime
([#66](#66))
* require writable external buffer storage
([#58](#58))

### Features

* add owned typed arrays
([#68](#68))
([b92c2de](b92c2de))
* **js:** add exact u32 conversion
([#71](#71))
([d6b21e1](d6b21e1))
* **js:** add typed array toArray
([#70](#70))
([ab42ab0](ab42ab0))
* **js:** export module/namespace consts and enums
([#73](#73))
([76dc0db](76dc0db))


### Bug Fixes

* **dsl:** support class pointer arguments
([#50](#50))
([9dd2111](9dd2111))
* harden N-API boundary against JS-triggerable memory bugs
([#60](#60))
([fff76f3](fff76f3))
* isolate DSL class tags across addons
([#67](#67))
([3ab8c11](3ab8c11))
* manage external buffer lifetime
([#66](#66))
([d134a6a](d134a6a))
* **napi:** receive raw pointer out parameters
([#57](#57))
([fde4a9a](fde4a9a))
* remove redundant platform check from musl detection
([#64](#64))
([0d4829c](0d4829c))
* require writable external buffer storage
([#58](#58))
([8fd898f](8fd898f))
* restore registerDecls on Zig 0.16
([#59](#59))
([7f3af3e](7f3af3e))


### Code Refactoring

* **js:** unify env lifecycle refcounting
([#53](#53))
([d3d5056](d3d5056))


### Miscellaneous Chores

* define changelog sections for release-please
([#54](#54))
([1c5e7b4](1c5e7b4))
* update dev deps ([#74](#74))
([5121590](5121590))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants