Repository navigation
fix(hl-perf-chart): hide users line/legend/stat when no daily unique users data - #852
Merged
Merged
Conversation
bakabhai993
pushed a commit
to bakabhai993/OpenChainBench
that referenced
this pull request
Sep 12, 2026
…users data (ChainBench#852) Co-authored-by: Florent Tapponnier <contact@openchainbench.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On 90d/1y the DuckDB archive does not carry per-day unique users, so
peakUserscollapses to 0. The chart was still drawing a flat-zero users line, a Users legend entry, right-side Y-axis tick labels and a "Peak users / day" stat that all read 0 — misleading.Guard the whole users overlay (line, area, hover dots, right axis, legend chip, tooltip row, footer stat) on
peakUsers > 0instead of hard-codingrange === "30d". When a future upstream starts serving per-day uniques for 90d/1y it will just light up.Test plan
/hyperliquid/phantom-perpson 30d: users overlay visible/hyperliquid/phantom-perpson 1y: users overlay hidden, only revenue rendered/hyperliquid/ccxton 1y: users overlay hidden