Repository navigation
the badge I just fixed says "Measurement pending" about a measurement we have - #3405
Merged
Merged
Conversation
… we have Verified on staging after #3402 landed, which is how this surfaced: alchemy ?chain=robinhood "measurement pending" alchemy unscoped "measurement pending" quicknode ?chain=robinhood "#4/6 (Robinhood Chain), 91.1%" (control) The guard works: Alchemy no longer claims a rank and a ranked provider still answers. The wording does not. Alchemy's figure exists, 100.0 percent over the 12 cells we could ask, and the board publishes it with its cause. Only the RANK is withheld. placeholderSvg hardcodes "Measurement pending" in the aria-label, the <title> and the visible line, so my guard replaced a false rank with a false status, which is the same fault facing the other way. placeholderSvg now takes an optional status line. The default is unchanged, so the three callers that mean it keep saying "Measurement pending": a transient scoped miss, an unknown cell, a bench with no cell data. The unranked path passes "Not ranked". NO FIGURE IN THE BADGE, deliberately, and this is the part I changed my mind on My first version read `Not ranked · ${fmtUnit(providerRow.ms.p50, b.unit)}`. That is wrong for the same reason rankOfChain was: `b` is the unfiltered bench, so under a ?chain= request it would print a cross-chain value behind a scoped label. It happens to be invisible on this bench, because Alchemy reads 100.0 both all-chains and on Robinhood, and it would be a live defect on any bench where those differ. "Not ranked" is true on every scope and asserts no number; the board carries the figure. So: a badge that cannot defend a position says so, and says nothing else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified on staging after #3402 landed, which is how this surfaced:
The guard works: Alchemy no longer claims a rank and a ranked provider still
answers. The wording does not. Alchemy's figure exists, 100.0 percent over the
12 cells we could ask, and the board publishes it with its cause. Only the
RANK is withheld. placeholderSvg hardcodes "Measurement pending" in the
aria-label, the <title> and the visible line, so my guard replaced a false rank
with a false status, which is the same fault facing the other way.
placeholderSvg now takes an optional status line. The default is unchanged, so
the three callers that mean it keep saying "Measurement pending": a transient
scoped miss, an unknown cell, a bench with no cell data. The unranked path
passes "Not ranked".
NO FIGURE IN THE BADGE, deliberately, and this is the part I changed my mind on
My first version read
Not ranked · ${fmtUnit(providerRow.ms.p50, b.unit)}.That is wrong for the same reason rankOfChain was:
bis the unfilteredbench, so under a ?chain= request it would print a cross-chain value behind a
scoped label. It happens to be invisible on this bench, because Alchemy reads
100.0 both all-chains and on Robinhood, and it would be a live defect on any
bench where those differ. "Not ranked" is true on every scope and asserts no
number; the board carries the figure.
So: a badge that cannot defend a position says so, and says nothing else.