Repository navigation
live dashboard: drop zkSync Era, which held a slot and published a dash - #3316
Merged
Merged
Conversation
It had a legend entry, a brand colour and a polyline on the streamed volume chart while the relay sent it no volume at all, so the only figure the dashboard ever printed for it was "-". Every other chain in that legend carries a number. A swap whose chain is not in CHAIN_LIST is dropped by the dashboard before it reaches the feed or the buckets, which is what should happen here: there is nothing to drop. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zkSync Era sat in the streamed volume legend of the live dashboard with a brand colour and a polyline, and the only figure it ever printed was
-. Every other chain in that legend carries a number.Removing it from
CHAIN_LISTtakes it out of the legend, the chart, the hover card and the per-chain buckets in one place, since all four read that list.dashboard.tsxdrops a swap whose chain is not in the list (if (!meta) return;) before it reaches the feed or the buckets. That is the right behaviour here: the relay publishes no zkSync volume, so there is nothing being thrown away. The logo and the chain's entries elsewhere (RPC pages, registry,evm-chain-ids) are untouched.A comment on the list says why, so it does not come back as a presumed oversight.
Gates:
tsc --noEmitclean,bun test src/731 pass 0 fail.