Repository navigation
three rows on the privacy boards were rendering as initials - #3303
Merged
Merged
Conversation
Maya Protocol as MP, Dash as DA, Zcash as ZC. Two needed a mark and one needed nothing at all. ZEC ALREADY HAD ONE. public/logos/zcash.svg has been in the manifest all along and the bench calls the provider "zec", so the lookup missed by a name. The slug cannot simply be renamed: the spec validator ties a provider slug to the label value its queries select, and asset="ZEC.ZEC" is the venue's own asset id, so "zcash" is rejected. The manifest gains the alias instead, which is the right direction: the mark adapts to the measurement, not the measurement to the mark. MAYA had no mark anywhere, and public/logos/mayan.svg was NOT reused. Mayan Finance and Maya Protocol are different protocols, and a wrong mark on a board is worse than initials. The 256x256 square mark comes from their own site. Their SVG isotype was rejected for shape rather than content: at 222x100 it is a 2.2:1 strip that would letterbox in a round slot, where every existing mark sits between 1.00 and 1.13. DASH had the same problem in a sharper form. The wordmark on their media server is 1398x368.9, a 3.8:1 strip with the word in it. The square icon is used instead at 1.19:1, which is the ratio nordstern already ships at. Both files were scanned before being served from our origin, because an SVG is executable content: no script, no foreignObject, no external href or url(), no off-origin image. All three also gain a registry entry. The lesson is this week's: nordstern had a logo and no entry, so its product page carried no official link and no description until #3273. A mark without an entry is a half-fix. providers v21 to v22, because product pages change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maya Protocol as MP, Dash as DA, Zcash as ZC. Two needed a mark; one needed nothing at all.
ZEC already had one
public/logos/zcash.svghas been in the manifest all along, and the bench calls the providerzec— the lookup missed by a name.The slug cannot simply be renamed: the spec validator ties a provider slug to the label value its queries select, and
asset="ZEC.ZEC"is the venue's own asset id, sozcashis rejected. The manifest gains the alias instead, which is the right direction — the mark adapts to the measurement, not the measurement to the mark.Maya
No mark anywhere, and
public/logos/mayan.svgwas not reused: Mayan Finance and Maya Protocol are different protocols, and a wrong mark on a board is worse than initials. The 256x256 square mark comes from their own site.Their SVG isotype was rejected for shape, not content: at 222x100 it is a 2.2:1 strip that would letterbox in a round slot, where every existing mark sits between 1.00 and 1.13.
Dash
Same problem, sharper. The wordmark on their media server is 1398x368.9 — a 3.8:1 strip with the word in it. The square icon is used instead at 1.19:1, the ratio nordstern already ships at.
Both files were scanned before being served from our origin, because an SVG is executable content: no
script, noforeignObject, no externalhreforurl(), no off-originimage.All three also gain a registry entry
This week's lesson: nordstern had a logo and no entry, so its product page carried no official link and no description until #3273. A mark without an entry is a half-fix.
providersv21 to v22, because product pages change.Gates:
pnpm validate256 specs,tsc --noEmitclean,bun test src/731 pass.